Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #306560: Toolbar zoom box does nothing #6199

Merged

Conversation

Spire42
Copy link
Contributor

@Spire42 Spire42 commented Jun 10, 2020

Resolves: #306560

Fixed a problem introduced in #306509 that caused the new zoom level to fail to be applied if the user tried to change it using the toolbar zoom box.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Fixed a problem introduced in #306509 that caused the new zoom level to fail to be applied if the user tried to change it using the toolbar zoom box.
@Spire42 Spire42 force-pushed the 306560-toolbar-zoom-box-does-nothing branch from 14c40ee to ef27a69 Compare June 10, 2020 11:52
@anatoly-os anatoly-os merged commit a56bb1a into musescore:3.x Jun 10, 2020
anatoly-os added a commit that referenced this pull request Jun 10, 2020
…thing

Fix #306560: Toolbar zoom box does nothing
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants