-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #306603: Measure number vertical offset interpreted incorrectly #6208
Conversation
Why such a big change to |
Tested and works as expected, thanks! |
Marked as wip because the offset for above is still used when importing measure numbers with pos below... @mattmcclinch it's true that there's more line changes than needed in editstyle.ui, but that's because of qtcreator, and by using .ui files, we accept that qtcreator saves as he likes the file. I could modify it, but it would take more time than it should and for a little bit more than 100 lines, I don't think it's needed. |
ef249ab
to
a15b54e
Compare
I went ahead and cleaned up your changes to |
Definitely nicer, thanks for that, @mattmcclinch . It's "OK" as is but would be much better with that change. |
Thank you! You are right, it is nicer that way. |
@mattmcclinch I rebased with your version. Thanks again! |
Resolves: https://musescore.org/en/node/306603
See this comment for details