Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #306832 - AppImage doesn't store the correct wallpaper filename f… #6227

Merged
merged 1 commit into from
Jun 22, 2020

Conversation

njvdberg
Copy link
Contributor

…or Background and Paper

Resolves: https://musescore.org/en/node/306832 (partially)

When for the foreground a wallpaper is selected but the file is not found, ScoreView falls back on the foreground color White. However, in ExampleView the foreground color _fgColor wasn't set so it falls back on the default color Black.
Now the default foreground color of ExampleView is also set to white.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

…or Background and Paper

Resolves https://musescore.org/en/node/306832 (partially)

When for the foreground a wallpaper is selected but the file is not found, ScoreView
falls back on the foreground color white. However, in ExampleView, the foreground
_fgColor wasn't set so it falls back on the default color black.
Now the default foreground color of ExampleView is also set to white.
@anatoly-os anatoly-os merged commit 0ea9283 into musescore:3.x Jun 22, 2020
@njvdberg njvdberg deleted the issue-306832-exampleview-fg branch July 1, 2020 12:41
anatoly-os added a commit that referenced this pull request Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants