Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #307075 : Bold and underlined text is not displayed properly unde… #6246

Merged
merged 1 commit into from
Jun 23, 2020

Conversation

AntonioBL
Copy link
Contributor

…r Windows and Linux

Resolves: https://musescore.org/en/node/307075

The workaround of eb33bfa83 introduced a side effect for texts when they are bold and underlined at the same time.
This PR reverts to the previous behavior for this particular case. This means that for some particular fonts, when the texts are at the same time bold and underlined, bug https://musescore.org/en/node/284218 will appear again (as in MuseScore 3.4.2). For Windows and Linux.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [N/A] I created the test (mtest, vtest, script test) to verify the changes I made

@anatoly-os anatoly-os merged commit 14d7f0f into musescore:3.x Jun 23, 2020
anatoly-os added a commit that referenced this pull request Aug 20, 2020
@AntonioBL AntonioBL deleted the boldunderlined branch October 26, 2020 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants