fix #307005: chord playback default not consistent #6247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anatoly-os
reviewed
Jun 24, 2020
libmscore/layout.cpp
Outdated
| if ((harmony && e->isHarmony()) || (!harmony && e->isFretDiagram())) | ||
| staves[e->staffIdx()].append(e); | ||
| if ((harmony && e->isHarmony()) || (!harmony && e->isFretDiagram())) { | ||
| if (e->autoplace() && e->isStyled(Pid::OFFSET)) |
There was a problem hiding this comment.
How does this change relate to the chord playback?
There was a problem hiding this comment.
Ooops, it doesn't, I was helping test something else about layout and I guess I didn't notice this was still there. I'll update.
We do still need to resolve the question of how to handle the default, and whether we special case old scores, force playback sound to piano, or any of the other things we've discussed. But first step is removing the preference pretty much no matter what.
Resolves: https://musescore.org/en/node/307005 Currently chord symbols playback is off by default controlled by a global program preference. This means a given user has to learn the feature exists before using it, which is not how we handle playback of dynamics, ornaments, etc. And worse, it means a user might turn it on, hear the chord playback, save and share a score that relies on it, but the people he sahres it with (including musescore.com) will not hear the chords unless they happen to have enabled the option. And musescore.com won't play it no matter what (or else, it will always play chords symbols for everyone, which isn't good either). This commit removes the preference and enables chord sytmbol playback according to the style setting and property on the chord symbol itself, which is exactly how it is done for ornaments etc. The style setting and property already existed, they were just being overridden by the program preference.
MarcSabatella
force-pushed
the
play-harmony-default
branch
from
872456d
to
8a7bc00
Compare
|
See also #6259 if we wish to have older scores disable chord symbol playback by default. |
This was referenced Jun 24, 2020
Merged
This was referenced Jul 10, 2020
anatoly-os
added a commit
that referenced
this pull request
Aug 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/307005
Currently chord symbols playback is off by default
controlled by a global program preference.
This means a given user has to learn the feature exists before using it,
which is not how we handle playback of dynamics, ornaments, etc.
And worse, it means a user might turn it on, hear the chord playback,
save and share a score that relies on it,
but the people he sahres it with (including musescore.com)
will not hear the chords unless they happen to have enabled the option.
And musescore.com won't play it no matter what
(or else, it will always play chords symbols for everyone,
which isn't good either).
This commit removes the preference and enables chord sytmbol playback
according to the style setting and property on the chord symbol itself,
which is exactly how it is done for ornaments etc.
The style setting and property already existed,
they were just being overridden by the program preference.