fix AppVeyor build #6294
Merged
fix AppVeyor build #6294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2020
|
Alternative: upload qt599_msvc2015.7z and qt599_msvc2017_64.7z (patched as per above) to https://utils.musescore.org.s3.amazonaws.com/ and modify |
29 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
at least for now...
The July 3rd update of AppVeyor updated to MSVC 16.6.3 (from 16.5.5), which triggers a Qt 5.9 bug
Another possible fix would be to patch Qt 5.9 as per https://codereview.qt-project.org/c/qt/qtbase/+/301315/1/src/corelib/tools/qlinkedlist.h, a rather simple 2-line change and we're using a 'private' Qt version anyhow. This though is nothing a PR could do.
I can provide archives with the patch.
As LTS for 5.9 had just ended in May, for master we'd better move to Qt 5.12.9 or 5.15.0 or later, which have the above bug fixed, but for 3.x we should IMHO better stay on Qt 5.9 (but maybe move to the latest 5.9.9, we're still using 5.9.8)
See also https://t.me/musescoreeditorchat/78898 ff.