Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #307741 images attached to measures don't propagate between score and existing parts #6330

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Fix #307741 images attached to measures don't propagate between score and existing parts #6330

merged 3 commits into from
Jul 14, 2020

Commits on Jul 12, 2020

  1. Revert "fix #292606: image attached to a measure doesn't show" 

    This reverts commit dd98fad, which made images added to measures children of the measure rather than children of the measure's first segment. This turned out to be not such a great idea after all, since it really only solved a problem that is better solved by simply turning off automatic placement for the image.
    @mattmcclinch
    mattmcclinch committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    f66a487 View commit details
    Browse the repository at this point in the history

  2. Fix #292606: image attached to a measure doesn't show 

    Be sure to layout images within Score::layoutSystemElements().
    @mattmcclinch
    mattmcclinch committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    e0fc497 View commit details
    Browse the repository at this point in the history

  3. Fix #307741: images attached to measures don't propagate between scor… 

    …e and existing parts

There is code to correctly deal with images, but it is not reached unless ElementType::IMAGE is excluded from what is handled earlier.
    @mattmcclinch
    mattmcclinch committed Jul 12, 2020
    Configuration menu
    Copy the full SHA
    3afc076 View commit details
    Browse the repository at this point in the history