-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix code style and enforce with GitHub Actions test #6358
Conversation
faf4f27
to
2f111a7
Compare
25a9fbc
to
11537bb
Compare
The previous syntax was not parsed correctly by Uncrustify, which would lead to symantic changes when running code style scripts.
Changes after running tools/codestyle/uncrustify_run.sh script.
Now that this has been merged, the code style test is enforced for all future PRs. However, pre-existing PRs will not been tested for coding style unless the GitHub Action for MacOS is triggered again (e.g. by pushing another commit to the PR branch). If you see this under a PR, it has not been tested for coding style: PRs that have been tested will be labelled like this: (notice that the MacOS Action name begins with "codestyle") Regardless of test status, coding style needs to be fixed before PRs are merged otherwise the test will start to fail for everybody. |
Resolves: No issue in tracker
Strictly enforcing the code style will make it easier to cherry-pick commits from the 3.x branch.