fix #308371: wrong stem directions on tab staves with multiple voices #6391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/308371 For 3.5 we changes the hasVoices() algorithm, used to determine default stem direction and other things, to look at partial measures rather than full measures. Overall, that's a good thing, but there are cases where it isn't. While there will probably always be deabte on some corner cases and there probably is no good algorithmic way of differentiating them, one thing that seems clear is the rules for using voices on tab staves is totally different, and this partial method does not work well. You end up with notes having down stem even though they are in voice 1 and there is also content in voice 2, which just does not make sense in that context. So this change simply checks for tab and makes sure to look at the full measure in that case.
This was referenced Jul 29, 2020
MarcSabatella
referenced
this pull request
in mattmcclinch/MuseScore
Jul 29, 2020
…to flip in a bad and unexpected way
|
Manually merged to master (84ae2c3) |
anatoly-os
added a commit
that referenced
this pull request
Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/308371
For 3.5 we changes the hasVoices() algorithm,
used to determine default stem direction and other things,
to look at partial measures rather than full measures.
Overall, that's a good thing, but there are cases where it isn't.
While there will probably always be debate on some corner cases
and there probably is no good algorithmic way of differentiating them,
one thing that seems clear is the rules for using voices on tab staves
is totally different, and this partial method does not work well.
You end up with notes having down stem
even though they are in voice 1 and there is also content in voice 2,
which just does not make sense in that context.
So this change simply checks for tab and makes sure
to look at the full measure in that case.