Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #309419: instrument change data not properly saved in linked staves #6491

Merged

Conversation

elerouxx
Copy link
Contributor

Resolves: https://musescore.org/en/node/309419

Problem: Editing a Staff instrument on linked staves, after an instrument change, only changed the instrument for the first InstrumentChange element (the first staff). The changes apparently worked, but they were lost after saving and reloading the file (because the second staff's instrument change was written with the stock unchanged instrument).

Just added a loop in Edit Staff so it now finds all Instrument Changes on the part and its staves and sets all of them to the new instrument data.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • [NA] I created the test (mtest, vtest, script test) to verify the changes I made

@elerouxx elerouxx changed the title Fix #309419: instrument data not properly saved in linked staves Fix #309419: instrument change data not properly saved in linked staves Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants