fix #309754: Create Time Signatures dialogue doesn't need to add special text whenever the internal value of nominator or denominator is changed #6507
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree with the proposed change, but it does t address the issue linked, it resolves a different (related) issue not yet reported. So I’d suggested submitting that issue (involving dialog behavior) separately and amending the commit message here to refer to that instead. And then see about a fix for the much more critical regresssion originally reported. |
Harmoniker1
force-pushed
the
time_signature
branch
from
2a6d314
to
282f3ba
Compare
Harmoniker1
changed the title
…al text whenever the internal value of nominator or denominator is changed Special texts are useful just because they can be different from the internal values. There's no need of updating them if the internal values are changed, because they are either blank (and are most likely wished to still be blank, because then they won't affect the layout of the internal values for the time signature) or different from the original values (and are most likely wished to still be different, because if not, there's no point of having them). See more in https://musescore.org/node/308139#comment-1022250.
Harmoniker1
force-pushed
the
time_signature
branch
from
282f3ba
to
c8d70a9
Compare
29 tasks
Merged
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2020
introduced by musescore#6507
Jojo-Schmitz
reviewed
Sep 2, 2020
| @@ -127,7 +127,6 @@ void TimeDialog::save() | |||
|
|
|||
| void TimeDialog::zChanged(int val) | |||
| { | |||
| zText->setText(QString("%1").arg(val)); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/node/309754.
Special texts are useful just because they can be different from the internal values. There's no need of updating them if the internal values are changed, because they are either blank (and are most likely wished to still be blank, because then they won't affect the layout of the internal values for the time signature) or different from the original values (and are most likely wished to still be different, because if not, there's no point of having them).
See more in https://musescore.org/node/308139#comment-1022250.