fix #309760: chord symbols realized before executing dialog #6511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/309760 There is a command realize-chord-symbols that you can access from the tools menu or shortcut if you have defined it, and also a similarly item on the context menu for chord symbols. They are slightly differently, however - the command just runs, whereas the context menu brings up a dialog. Because they shared the same action, the context menu was actually executing both versions. This is fixed by creating a new action for the context menu. I reuse the name of the command but add an ellipsis, since it brings up a dialog. I suppose it's an open question why the behaviors should be different between invoking this from the Tools menu versus the context menu, but I'll wait until someone actually complains before changing it.
MarcSabatella
force-pushed
the
309760-realize-twice
branch
from
a98c681
to
d23fbf2
Compare
MarcSabatella
changed the title
The ellipsis definitely belongs here conceptually, but it might not always be correct in all languages to simply append it. So this really should be a new translatable string, but that change would have to wait for a release when this is OK. For now, leave the menu item as it was, just "Realize Chord Symbols".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/309760
There is a command realize-chord-symbols that you can access
from the tools menu or shortcut if you have defined it,
and also a similarly item on the context menu for chord symbols.
They are slightly differently, however -
the command just runs, whereas the context menu brings up a dialog.
Because they shared the same action,
the context menu was actually executing both versions.
This is fixed by creating a new action for the context menu.
I reuse the name of the command but add an ellipsis,
since it brings up a dialog.
I suppose it's an open question why the behaviors should be different
between invoking this from the Tools menu versus the context menu,
but I'll wait until someone actually complains before changing it.