fix #309852: undefined playback of chord symbol attached to fret diagram #6521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolves: https://musescore.org/en/node/309852 If a chord symbol has "Chord/Rest Duration" in its playback properties, and the chord symbol has a fret diagram as a parent, then the results are not defined, but can potentially crash, as we are casting the parent to a segment when it isn't. This yields an assertion failure in debug builds, just randomly bad results in release builds. Avoiding the crash is simple, I changed parent() to getParentSeg(). I realize, though, that segment duration isn't really the same as chord/rest duration, since there might be content on other tracks that results in the segment duration being shorter. Or, for that matter, another chord symbol on this track. Eventually we should look at really making this chord/rest duration. My initial attempt created corruption if there was in fact another chord symbol on the same track before the end of the current chord/rest duration. Fixing this is no doubt possible, and something to consider. I left a TODO for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/309852
If a chord symbol has "Chord/Rest Duration" in its playback properties,
and the chord symbol has a fret diagram as a parent,
then the results are not defined, but can potentially crash,
as we are casting the parent to a segment when it isn't.
This yields an assertion failure in debug builds,
just randomly bad results in release builds.
Avoiding the crash is simple, I changed parent() to getParentSeg().
I realize, though, that segment duration isn't really the same
as chord/rest duration, since there might be content on other tracks
that results in the segment duration being shorter.
Or, for that matter, another chord symbol on this track.
Eventually we should look at really making this chord/rest duration.
My initial attempt created corruption if there was in fact
another chord symbol on the same track before the end
of the current chord/rest duration.
Fixing this is no doubt possible, and something to consider.
I left a TODO for this.