Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acc padding #6956

Merged
merged 1 commit into from
Dec 8, 2020
Merged

Acc padding #6956

merged 1 commit into from
Dec 8, 2020

Conversation

ecstrema
Copy link
Contributor

@ecstrema ecstrema commented Nov 28, 2020

Resolves: https://trello.com/c/4jEoQVsR/22-add-padding-inside-parentheses-for-bracketed-accidentals

Add padding around bracketed accidentals

New:
image

Old:
image

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@ecstrema ecstrema marked this pull request as draft November 28, 2020 00:22
@ecstrema ecstrema force-pushed the acc-padding branch 5 times, most recently from 0381f62 to 3bd859a Compare November 28, 2020 07:01
@RobFog
Copy link

RobFog commented Nov 28, 2020

Shouldn't the .gitignore commit be in a separate pull request?

@ecstrema
Copy link
Contributor Author

Shouldn't the .gitignore commit be in a separate pull request?

I'll remove the commit when the PR is ready.

@ecstrema ecstrema marked this pull request as ready for review December 4, 2020 07:12
@Jojo-Schmitz
Copy link
Contributor

See also w3c/smufl#162

@ecstrema
Copy link
Contributor Author

ecstrema commented Dec 4, 2020

vtest failures are expected

@ecstrema
Copy link
Contributor Author

ecstrema commented Dec 4, 2020

recommended ligatures are not part of glyphnames.json. see w3c/smufl#162 Another fix will be needed for these.

@ecstrema ecstrema force-pushed the acc-padding branch 3 times, most recently from 6877303 to 7ae6f41 Compare December 7, 2020 21:34
@vpereverzev vpereverzev added the vtests This PR produces approved changes to vtest results label Dec 8, 2020
@vpereverzev
Copy link
Member

A rebase on the latest 3.x should fix these issues with mtests

@Jojo-Schmitz
Copy link
Contributor

A rebase on the latest 3.x should fix these issues with mtests

So you can as well just merge it

@ecstrema
Copy link
Contributor Author

ecstrema commented Dec 8, 2020

A rebase on the latest 3.x should fix these issues with mtests

So you can as well just merge it

Just pushed for formality.

@vpereverzev vpereverzev merged commit 8a6c7d8 into musescore:3.x Dec 8, 2020
@ecstrema ecstrema deleted the acc-padding branch December 8, 2020 21:45
igorkorsukov added a commit to igorkorsukov/MuseScore that referenced this pull request Feb 1, 2021
igorkorsukov added a commit that referenced this pull request Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
vtests This PR produces approved changes to vtest results
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants