Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Export hidden tempo text to MusicXML #7256

Merged
merged 1 commit into from
Mar 10, 2021

Conversation

matangover
Copy link

@matangover matangover commented Jan 16, 2021

Hidden tempo text is now exported as a <sound tempo="XX"/> element without a container <direction> element.

This is now in line with the way MuseScore imports <sound> elements, see: #7171

I changed testSound1 from a test with a reference to a roundtrip import-export test, because it is now fully supported. Some other test reference files had to be changed because they contain hidden tempo markings as well.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@matangover matangover changed the title Export hidden tempo text to MusicXML. Export hidden tempo text to MusicXML Jan 16, 2021
@Jojo-Schmitz
Copy link
Contributor

rebase needed.

Hidden tempo text is now exported as a <sound tempo="XX"/> element
without a container <direction> element.

This is now in line with the way MuseScore imports <sound> elements,
see: musescore#7171
@matangover
Copy link
Author

rebase done

@igorkorsukov igorkorsukov changed the title Export hidden tempo text to MusicXML [MU3] Export hidden tempo text to MusicXML Feb 5, 2021
@vpereverzev vpereverzev merged commit 4a06420 into musescore:3.x Mar 10, 2021
@Jojo-Schmitz
Copy link
Contributor

I wonder whether this would need to get ported to master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants