Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing glyphs in Gootville #7295

Merged
merged 1 commit into from
Jan 25, 2021
Merged

Add missing glyphs in Gootville #7295

merged 1 commit into from
Jan 25, 2021

Conversation

rettinghaus
Copy link
Contributor

@rettinghaus rettinghaus commented Jan 22, 2021

Resolves:
https://musescore.org/en/node/125251
https://musescore.org/en/node/125191
https://musescore.org/en/node/310421
https://musescore.org/en/node/312877

added glyphs:

  • 4stringTabClef
  • fermataLongHenzeAbove
  • fermataLongHenzeBelow
  • fermataShortHenzeAbove
  • fermataShortHenzeBelow
  • breathMarkTick
  • breathMarkUpbow
  • caesuraThick
  • caesuraShort
  • breathMarkSalzedo

fixed glyphs:

  • fixed scaling in timeSigParensLeft
  • fixed scaling in timeSigParensRight
  • fixed position of octaveParensLeft
  • fixed position of octaveParensRight

Also this updates the metadata file, which before was just a copy of the metadata file coming from Bravura. Now it contains the correct bounding box informations.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Jan 22, 2021

Why is the change to fonts/gootville/metadata.json so huge? More than 36.000 deleted lines?
Does that reflect the relative incompletness vs. Bravura?

@rettinghaus
Copy link
Contributor Author

Basically yes. It now only reflects the glyphs actually contained in the font.

@Jojo-Schmitz
Copy link
Contributor

I guess the vtest differeneces are to be expected?
Almost all look pretty small and harmless except maybe the one for ornamets?

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Apr 9, 2021

@rettinghaus maybe you'd like to check https://musescore.org/en/node/319778, esp. the part of the issue with the gap, apparently cause by your changed to the engraving defaults, esp. those for stemThickness (0.12 to 0.076) and staffLineThickness (0.13 to 0.08)
Then there's also https://musescore.org/en/node/319636 which seems a regression from your changes in this PR?

@rettinghaus
Copy link
Contributor Author

@Jojo-Schmitz I think these are different issues. Making the stemThickness actually smaller should not make them stick out the notehead. But the anchor points were missing in the updated metadata.json, so I added them back in and reversed the changes in the engravingDefaults. See #8082.

@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented May 11, 2021

@Jojo-Schmitz
Copy link
Contributor

Yes, it does...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants