Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #311788: gap between staff and end barline with courtesy clef #7361

Merged

Commits on Jan 28, 2021

  1. fix #311788: gap between staff and end barline with courtesy clef

    Resolves: https://musescore.org/en/node/311788
    
    A recent commit fixed some issues with courtesy clefs,
    but introduced a regression - courtesy clefs on invisible staves
    were not being ignored, causing the segment to be marked visible
    and rhen in turn the measure width to be recalculated
    as if the clef were visible.
    This puts the barline too far to the right,
    with gap between the end of the staff and the barline.
    The clef itself was still ignored in the width calculation,
    so the discrepancy is not large -
    only the size of the margins before and after the clef.
    
    Fix is to skip invisible staves in the code that is checking
    for measures that need their width recalculated.
    
    AIn debugging this, I became aware this clef on an invisible staff
    was also appearing to affect the skyline of the visible staff,
    leading me on a wild goose chase,
    But that turns out to be an illusion -
    the clef is not added to the skyline of the visible staff at all.
    It's just that the skyline drawing code
    (used when turning "Show Skylines" in the Debug menu)
    is *also* failing to skip invisible staves.
    So I have fixed that as well.
    MarcSabatella committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    01372d4 View commit details
    Browse the repository at this point in the history