Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solves potential crash when an extended instruments.xml is written. #7405

Merged
merged 1 commit into from
Feb 3, 2021

Conversation

njvdberg
Copy link
Contributor

@njvdberg njvdberg commented Feb 3, 2021

Solves potential crash when an extended instruments.xml is written.
It never happened because that function is disabled at 2018-06-05.

Resolves an error introduced in PR #6479

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

It never happened because that function is disabled at 2018-06-05.
@vpereverzev vpereverzev merged commit 14d45d4 into musescore:3.x Feb 3, 2021
njvdberg added a commit to njvdberg/MuseScore that referenced this pull request Feb 15, 2021
… when an extended instruments.xml is written. It never happened because that function is disabled at 2018-06-05.
RomanPudashkin added a commit that referenced this pull request Feb 15, 2021
@njvdberg njvdberg deleted the possible_family_crash branch March 11, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants