-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #305387: Add spinner for controlling glissando line thickness in inspector #7435
Merged
vpereverzev
merged 1 commit into
musescore:3.x
from
sidharth-anand:305387-glissando-thickness-control
Feb 8, 2021
Merged
Fix #305387: Add spinner for controlling glissando line thickness in inspector #7435
vpereverzev
merged 1 commit into
musescore:3.x
from
sidharth-anand:305387-glissando-thickness-control
Feb 8, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I tested it and noticed two things:
|
I'll update the pr with these fixes |
Ah, for the first one, it looks like you need to add this: void InspectorGlissando::setElement()
{
InspectorElementBase::setElement();
if (!g.playGlissando->isChecked()) {
g.labelGlissandoStyle->setEnabled(false);
g.glissandoStyle->setEnabled(false);
g.resetGlissandoStyle->setEnabled(false);
}
if (!g.showText->isChecked())
g.textWidget->setVisible(false);
+ g.lineWidthWidget->setHidden(g.type->currentIndex() == 1);
g.easeInSlider->setSliderPosition(g.easeInSpin->value());
g.easeOutSlider->setSliderPosition(g.easeOutSpin->value());
g.easeInOutCanvas->setEaseInOut(g.easeInSpin->value(), g.easeOutSpin->value());
updateEvents();
} |
sidharth-anand
force-pushed
the
305387-glissando-thickness-control
branch
from
February 5, 2021 16:19
9ff4be8
to
7877f30
Compare
Updated with both the fixes |
53 tasks
Jojo-Schmitz
approved these changes
Feb 7, 2021
Needs #7704 |
I wonder whether this would need to get ported to master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/305387
This patch allows the user to directly change the thickness of the glissando line from the inspector