Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #315904: [MusicXML import] incomplete import from ScoreScan XML file #7442

Merged
merged 1 commit into from
Feb 8, 2021

Conversation

lvinken
Copy link
Contributor

@lvinken lvinken commented Feb 7, 2021

Resolves: https://musescore.org/en/node/315904

An incorrect readNext() caused the MusicXML parser to get out of sync
if no white space is present between the end elements of fingering
and technical. This is legal but seems to occur only in files produced
by ScanScore. It results in incomplete import.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

Resolves: https://musescore.org/en/node/315904

An incorrect readNext() caused the MusicXML parser to get out of sync
if no white space is present between the end elements of fingering
and technical. This is legal but seems to occur only in files produced
by ScanScore. It results in incomplete import.
@vpereverzev vpereverzev merged commit 9c35ca1 into musescore:3.x Feb 8, 2021
@igorkorsukov
Copy link
Contributor

@lvinken Could you please port the changes to the master

@lvinken
Copy link
Contributor Author

lvinken commented Feb 28, 2021

Sure. As, due to recent changes (CMake, Qt and C++ upgrades required) I do not have (and will not have for some time) a working build environment for master, I cannot validate the PR myself.

For this PR the changes are trivial and any issue will be found by the continuous integration tests, so I can still create the PR.

@lvinken
Copy link
Contributor Author

lvinken commented May 29, 2021

Finally created a working build environment for master, copied the two trivial required changes from 3.x (related testfiles have already been synced) and validated the PR.

@Jojo-Schmitz
Copy link
Contributor

Sorry, I must have missed that one, else I had ported it.

@lvinken
Copy link
Contributor Author

lvinken commented May 30, 2021 via email

@lvinken lvinken deleted the 315904-incomplete-import branch September 21, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants