Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #317426: Rests grouped incorrectly after adding 256th note or smaller #7518

Merged
merged 1 commit into from
Mar 10, 2021
Merged

Fix #317426: Rests grouped incorrectly after adding 256th note or smaller #7518

merged 1 commit into from
Mar 10, 2021

Commits on Feb 12, 2021

  1. Fix #317426: Rests grouped incorrectly after adding 256th note or sma… 

    …ller.

Resolves: https://musescore.org/en/node/317426.

The functions that deal with rhythm grouping operate on integer ticks, but they are smart enough to realize that integers can only be split in half so many times. If and when this limit is exceeded, populateRhythmicList gives up trying to group rhythms based on subbeats, and simply appends the result of toDurationList() to the current duration list that is being built. But toDurationList() returns a list that is ordered from largest to smallest, so it really ought to be appended in the reverse order.
    @mattmcclinch
    mattmcclinch committed Feb 12, 2021
    Configuration menu
    Copy the full SHA
    bfecbad View commit details
    Browse the repository at this point in the history