[MU3] Fix detection of even/odd lyrics #7628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shamelessly stolen from #7627 and fixed the still wrong logic ;-) (
_no
is zero based, see discussion in #7627 (comment))Might (!?) resolve:
Well, maybe not, as that
Lyrics::isEven()
isn't actually used anywhere. So yes, it is a bug, but in (currently) unused code, as far as I can tell.In lyrics.cpp it uses
(_no & 1)
for this purpose and in 3 different places.But #6021 does make use of this (and fixes it the very same way)