[MU3] [DAISY] backport of master fixes to 3.x #7870

Jojo-Schmitz · 2021-04-02T07:53:05Z

@shoogle's fixes (all still in draft currently):

[DAISY] Fix #298147 MusicXML: Handle measure number offsets ([DAISY] Fix #298147 MusicXML: Handle measure number offsets #7617)
[DAISY] Fix #269926 MusicXML: Fermatas on notes with grace notes ([DAISY] Fix #269926 MusicXML: Fermatas on notes with grace notes #7621)
[DAISY] Fix #303450 MusicXML: Text in voice 2 not placed correctly ([DAISY] Fix #303450: Text in voice 2 not placed correctly #7863)
[DAISY] Fix #307442 Accessibility: Speech for tuplets with more than 9 notes ([DAISY] Accessibility: Improve speech for various elements #8877, part 1)
[DAISY] Fix #312625 Accessibility: Speak notehead group type ([DAISY] Accessibility: Improve speech for various elements #8877, part 2)

Jojo-Schmitz · 2021-04-02T12:22:44Z

I wonder why those mtest failures don't happen in master, are those tests disabled there? They seem (largely) related to measure numbers (and some <divisions>1</divisions>)

If anything, this does show the usefulness of having such PRs for both, 3.x and master...

shoogle · 2021-04-03T01:12:21Z

If anything, this does show the usefulness of having such PRs for both, 3.x and master...

It shows the usefulness of automated tests, which we should enable on the master branch.

The plan is to not release another version in the 3.x series except in an emergency, and even then it would only fix the emergency, not provide new functionality. People should avoid working on the 3.x branch unless and until that plan changes.

Previously it was assumed that measure numbers always started at 1 and increased by 1 for each regular measure. Now the actual measure numbers given in the MusicXML are used within MuseScore during import to calculate measure number offsets. During export, these offsets are converted back into absolute numbers for use in the MusicXML. Backport of musescore#7617, resp. duplicate of musescore#7870

Previously, if a note had both a fermata and a grace note then the grace note would gain a fermata during export. Backport of musescore#7621, resp. duplicate of musescore#7870

Backport of musescore#7863, resp. duplicate of musescore#7870

Previously it was assumed that measure numbers always started at 1 and increased by 1 for each regular measure. Now the actual measure numbers given in the MusicXML are used within MuseScore during import to calculate measure number offsets. During export, these offsets are converted back into absolute numbers for use in the MusicXML. Backport of musescore#7617, resp. duplicate of musescore#7870

Previously, if a note had both a fermata and a grace note then the grace note would gain a fermata during export. Backport of musescore#7621, resp. duplicate of musescore#7870

Backport of musescore#7863, resp. duplicate of musescore#7870

Previously it was assumed that measure numbers always started at 1 and increased by 1 for each regular measure. Now the actual measure numbers given in the MusicXML are used within MuseScore during import to calculate measure number offsets. During export, these offsets are converted back into absolute numbers for use in the MusicXML. Backport of musescore#7617, resp. duplicate of musescore#7870

Previously, if a note had both a fermata and a grace note then the grace note would gain a fermata during export. Backport of musescore#7621, resp. duplicate of musescore#7870

Backport of musescore#7863, resp. duplicate of musescore#7870

Previously it was assumed that measure numbers always started at 1 and increased by 1 for each regular measure. Now the actual measure numbers given in the MusicXML are used within MuseScore during import to calculate measure number offsets. During export, these offsets are converted back into absolute numbers for use in the MusicXML. Backport of musescore#7617, resp. duplicate of musescore#7870

Previously, if a note had both a fermata and a grace note then the grace note would gain a fermata during export. Backport of musescore#7621, resp. duplicate of musescore#7870

Backport of musescore#7863, resp. duplicate of musescore#7870

Previously it was assumed that measure numbers always started at 1 and increased by 1 for each regular measure. Now the actual measure numbers given in the MusicXML are used within MuseScore during import to calculate measure number offsets. During export, these offsets are converted back into absolute numbers for use in the MusicXML. Backport of musescore#7617, resp. duplicate of musescore#7870

Previously, if a note had both a fermata and a grace note then the grace note would gain a fermata during export. Backport of musescore#7621, resp. duplicate of musescore#7870

Backport of musescore#7863, resp. duplicate of musescore#7870

Previously it was assumed that measure numbers always started at 1 and increased by 1 for each regular measure. Now the actual measure numbers given in the MusicXML are used within MuseScore during import to calculate measure number offsets. During export, these offsets are converted back into absolute numbers for use in the MusicXML. Backport of musescore#7617, resp. duplicate of musescore#7870

Previously, if a note had both a fermata and a grace note then the grace note would gain a fermata during export. Backport of musescore#7621, resp. duplicate of musescore#7870

Backport of musescore#7863, resp. duplicate of musescore#7870

Previously it was assumed that measure numbers always started at 1 and increased by 1 for each regular measure. Now the actual measure numbers given in the MusicXML are used within MuseScore during import to calculate measure number offsets. During export, these offsets are converted back into absolute numbers for use in the MusicXML. Backport of musescore#7617, resp. duplicate of musescore#7870, likely a culprit for mtest failures