[MU4] Fix #7970: Help > About... Replace link to donate page, change text, say GPL version, say build etc. #7988
Conversation
Jojo-Schmitz
force-pushed
the
about-master
branch
5 times, most recently
from
cd875c8
to
71645c1
Compare
Jojo-Schmitz
force-pushed
the
about-master
branch
from
71645c1
to
bf49a86
Compare
|
This is how it now looks: Clipboard content (on my PC): OS: Windows 10 Version 2009, Arch.: x86_64, MuseScore version (64-bit): 4.0.0-767298131, revision: github-musescore-musescore-abc123456 Darn, just spotted a typo... ("it" vs. "its") |
Jojo-Schmitz
force-pushed
the
about-master
branch
2 times, most recently
from
c44d8e2
to
10b85b0
Compare
src/appshell/view/aboutmodel.cpp
Outdated
| @@ -36,7 +38,7 @@ AboutModel::AboutModel(QObject* parent) | |||
|
|
|||
| QString AboutModel::museScoreVersion() const | |||
| { | |||
| return QString::fromStdString(configuration()->museScoreVersion()); | |||
| return QString::fromStdString(configuration()->museScoreVersion()) + (mu::framework::Version::unstable() ? " development build" : ""); | |||
There was a problem hiding this comment.
We normally try to make a distinction between "development build" (PR build) and "nightly build" (master branch). Is it possible to access the BUILD_CONFIG string here? If not then I think we should just say "unstable prerelease" or something like that here.
There was a problem hiding this comment.
Well, we don't, never did as far as I can tell, in 3.x we used "Unstable prerelease of 3..." if and when Version::unstable() returned true . We can use that wording for master too of course, but that's not really what you originally requested?
"development build" is the new name for "nightly build" (and since quite long), so the same thing really.
I'm not sure whether we can distinguish a PR artifact from a build of a merged PR.
BUILD_CONFIG would be "dev" in either case, as far as I can tell. that would change with a beta or release, see CMakeLists.txt:
set(MUSESCORE_BUILD_CONFIG "dev" CACHE STRING "Build config")
# Possible MUSESCORE_BUILD_CONFIG values:
# - dev - for development/nightly builds
# - testing - for testing versions (alpha, beta, RC)
# - release - for stable release builds
There was a problem hiding this comment.
I originally requested "developer build" or "nightly build" (i.e. use the one that is most appropriate for a given build), but you are correct that the config string doesn't make this distinction anymore. Nightly still appears in the CI scripts but you won't have access to it here.
TLDR: Ok, let's stick with "development build" then.
There was a problem hiding this comment.
Should it be translatable? The old term "Unstable Prerelease for Version: %1" was translatable.
It would be actually only translated after the 4.0 translation round starts, so around a Beta, but that's true for very many strings.
There was a problem hiding this comment.
There's no harm in translating the string, but I don't think it really matters. It doesn't appear in release builds, and anybody using a development build would have had to navigate through the nightly builds page or one of the compilation guides, all of which are only available in English.
There was a problem hiding this comment.
I though so too. So will leave it as is.
What the heck... why not just do it the same way as in 3.x. Or at least similar (Ignore the missing SHA):
Translable too. Just let me know.
Ah, just let's do it
Jojo-Schmitz
force-pushed
the
about-master
branch
from
10b85b0
to
1c95db0
Compare
…ge text, say GPL version, say build etc. and keep HTML out of translatable text as far as possible
Useful for pasting into a forum topic or issue. Same to what MuseScore 3.x provided.
Jojo-Schmitz
force-pushed
the
about-master
branch
from
1c95db0
to
a99b3b0
Compare
|
Revision is still not right though... |
Resolves: #7970