[MU4] Fix #316504: Update MusicXML Import of Fretboard Diagrams #8014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
Jojo-Schmitz
force-pushed
the
fretboard-diagram-musicxml-import
branch
from
3aff73d
to
48a0e95
Compare
src/libmscore/fret.cpp
Outdated
| @@ -1333,6 +1333,7 @@ void FretDiagram::writeMusicXML(XmlWriter& xml) const | |||
| xml.tag("fret", "0"); | |||
| xml.etag(); | |||
| } else { | |||
There was a problem hiding this comment.
Careful, I explicitly removed this else statement for a reason in original PR :)
There was a problem hiding this comment.
oops
Better now?
Jojo-Schmitz
force-pushed
the
fretboard-diagram-musicxml-import
branch
from
48a0e95
to
6eb7823
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 11, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
8 tasks
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 28, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Duplicate of musescore#7455, resp. backport of musescore#8014
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Duplicate of musescore#7455, resp. backport of musescore#8014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: https://musescore.org/en/node/316504
Port of #7455 to master