Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #320126: Grace note slash layout #8106

Closed
wants to merge 2 commits into from
Closed

Fix #320126: Grace note slash layout #8106

wants to merge 2 commits into from

Conversation

laturetab
Copy link
Contributor

This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

  • [x ] I signed CLA
  • I made sure the code in the PR follows the coding rules
  • [x ] I made sure the code compiles on my machine
  • [x ] I made sure there are no unnecessary changes in the code
  • [x ] I made sure the title of the PR reflects the core meaning of the issue you are solving
  • [x ] I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • [x ] I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

laturetab and others added 2 commits May 14, 2021 09:20
@laturetab
Fix #320126: Grace note slash layout
dbc532f 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.
@laturetab
Update chord.cpp
eed948d
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 20, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
6eae751 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8106 to 3.x
@laturetab laturetab closed this May 21, 2021
@laturetab laturetab deleted the gracenoteslashlayout branch May 21, 2021 11:37
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 21, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
dbd2e89 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 (formerly musescore#8106) to 3.x
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jun 2, 2021
Closed
1 task
@Jojo-Schmitz
Copy link
Contributor

continued in #8137

Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 28, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
93f25eb 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 1, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
b198e2f 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
68712f5 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
10d49ee 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
eb3898a 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
9e3ee4b 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
2de7f4a 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
57f75a4 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
0e89f80 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
fb2b686 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
52beddc 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
15a275c 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
e215a7a 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
e593e0d 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
08e596e 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 2, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
a59ea12 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
4b0fab4 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@laturetab @Jojo-Schmitz
Fix #320126: Grace note slash layout
206e38d 
This will fix 2 bugs - grace notes slashes will now show up in TAB-COMMON and the slashes will no longer be stranded above the staff when switching between TAB-COMMON and TAB-FULL.

Backport of musescore#8137 / musescore#8106 (both closed meanwhile) to 3.x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laturetab @Jojo-Schmitz