-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3 Backend] ENG-30: Change non-end melismas to hyphens #8133
Merged
vpereverzev
merged 1 commit into
musescore:3.6.2_backend
from
iveshenry18:ENG-30-lyric-hyphens
May 21, 2021
Merged
[MU3 Backend] ENG-30: Change non-end melismas to hyphens #8133
vpereverzev
merged 1 commit into
musescore:3.6.2_backend
from
iveshenry18:ENG-30-lyric-hyphens
May 21, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case.
iveshenry18
changed the title
ENG-30: Change non-end melismas to hyphens
[MU3 Backend] ENG-30: Change non-end melismas to hyphens
May 21, 2021
oktophonie
approved these changes
May 21, 2021
vpereverzev
approved these changes
May 21, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 21, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 28, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 1, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Melismas in the middle of words were previously incorrectly imported as normal extensions, resulting in a underscore-style extension marking. This commit adds a check to make sure a lyric is either Syllabic::SINGLE or Syllabic::END before treating it as an extended lyric, which results in the mid-word melismas correctly being marked by a hyphen. It also adds a test for this specific case. Port of musescore#8133
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: ENG-30
Melismas in the middle of words were previously incorrectly imported
as normal extensions, resulting in an underscore-style extension marking.
This commit adds a check to make sure a lyric is either Syllabic::SINGLE
or Syllabic::END before treating it as an extended lyric, which
results in the mid-word melismas correctly being marked by a hyphen.
It also adds a test for this specific case.