-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3 Backend] ENG-23: Infer transpositions for guitar staves #8358
Merged
vpereverzev
merged 1 commit into
musescore:3.6.2_backend
from
iveshenry18:ENG-23-transpose-inference
Jun 29, 2021
Merged
[MU3 Backend] ENG-23: Infer transpositions for guitar staves #8358
vpereverzev
merged 1 commit into
musescore:3.6.2_backend
from
iveshenry18:ENG-23-transpose-inference
Jun 29, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oktophonie
approved these changes
Jun 22, 2021
iveshenry18
force-pushed
the
ENG-23-transpose-inference
branch
from
June 22, 2021 17:15
2e8dcbe
to
3dca1d6
Compare
rebase needed |
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`.
iveshenry18
force-pushed
the
ENG-23-transpose-inference
branch
from
June 29, 2021 00:03
3dca1d6
to
aa23c4a
Compare
Rebased! |
vpereverzev
approved these changes
Jun 29, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jun 30, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning
8 tasks
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 1, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 5, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 6, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 13, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 27, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Dolet for Sibelius does not support transpositions, and thus exports the sounding pitch for guitar staves, resulting in notation an octave below where it ought to be. This adds a simple mechanism for inferring a part's transposition. Since a normal MusicXML part expects the correct written pitches, then applies the transposition to the sounding pitch, this also adds a part-wise mechanism for transposing the *written* pitch, called `_inferredTranspose`. Duplicate of musescore#8358, plus fixing a compiler warning, duplicate of musescore#8481
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: ENG-23: Guitar notated in wrong octave
Dolet for Sibelius does not support transpositions, and thus exports the
sounding pitch for guitar staves, resulting in notation an octave below
where it ought to be. This adds a simple mechanism for inferring a
part's transposition when transpositions aren't supported. Since a normal MusicXML part expects the correct
written pitches, then applies the transposition to the sounding pitch,
this also adds a part-wise mechanism for transposing the written
pitch, called
_inferredTranspose
.