[MU3 Backend] ENG-54: Staff Visibility #8430

iveshenry18 · 2021-06-25T02:02:52Z

Resolves: ENG-54: Show both staves of grand staff even when one is empty

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding
empty staves in a grand staff), this changes the hideWhenEmpty to
INSTRUMENT when creating the Staffs upon import. In the case that a
score part has a variable number of staves, it uses this to infer that
we do truly want HideMode::AUTO.

Previously, a staff's emptiness was calculated based on its note and
annotation content. Since this is evaluated before the system was laid
out, the system did not have pointers to its SpannerSegments. This
commit adds a way to include whether a staff has any spanners
(particularly pedal markings and hanging slurs) in assessing emptiness,
creating more consistent/expected hiding behavior in HideMode::AUTO.

I signed CLA
I made sure the code in the PR follows the coding rules
I made sure the code compiles on my machine
I made sure there are no unnecessary changes in the code
I made sure the title of the PR reflects the core meaning of the issue you are solving
I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
I made sure the commit message title starts with "fix #424242:" if there is a related issue
I created the test (mtest, vtest, script test) to verify the changes I made

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO.

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO.

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

Jojo-Schmitz · 2021-07-05T09:45:12Z

libmscore/layout.cpp

@@ -1339,6 +1343,12 @@ void Score::hideEmptyStaves(System* system, bool isFirstSystem)
                    && !(isFirstSystem && styleB(Sid::dontHideStavesInFirstSystem))
                    && hideMode != Staff::HideMode::NEVER)) {
                  bool hideStaff = true;
+                  for (auto spanner : spanners) {
+                        if (spanner.value->staff() == staff) {


There a (big!) problem with this: Voltas now cause an otherwise empty and therefor hidden top staff to become visible.
So all Voltas (and other 'system' type spanners, like "System Text Line") need to somehow get excluded from this check.

This is certainly important for the 3.6.2_backend but even more so when this PR gets ported over to master.

Simlpe fix seems to be to add && !spanner.value->systemFlag() to the condition here.

Good catch! I'll go ahead and make that tweak today, as well as add something to the test case to catch future regressions of that specific variety.

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review)

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review)

See musescore#8430 (review) and musescore#8527

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review) and musescore#8527

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review) and musescore#8527

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review) and musescore#8527

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review) and musescore#8527

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review) and musescore#8527

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review) and musescore#8527

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review) and musescore#8527

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review) and musescore#8527

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Duplicate of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Duplicate of musescore#8430, part 2

See musescore#8430 (review) and musescore#8527

Port of musescore#8430, part 2: Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Plus port of musescore#8527: This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred hen a spanner started on the first tick of the next system. Plus fixing a regression with hairpins, resulting in the next system's stafes to become unhidden

Port of musescore#8430, part 2: Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Plus port of musescore#8527: This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred hen a spanner started on the first tick of the next system. Plus fixing a regression with hairpins, resulting in the next system's staves to become unhidden

Port of musescore#8430, part 2: Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Plus port of musescore#8527: This commit tweaks the changes from commit 54ebee4 (which checks for spanners when assessing staff emptiness) and ignores spanners that are "system" spanners (such as voltas or system text). This prevents a false-positive unhiding in the case of such system spanners. Also, it prevents another false positive that occurred hen a spanner started on the first tick of the next system. Plus fixing a regression with hairpins, resulting in the next system's staves to become unhidden.

Since HideMode::AUTO behaves in uncommon ways for most scores (hiding empty staves in a grand staff), this changes the hideWhenEmpty to INSTRUMENT when creating the Staffs upon import. In the case that a score part has a variable number of staves, it uses this to infer that we do truly want HideMode::AUTO. Port of musescore#8430, part 1

Previously, a staff's emptiness was calculated based on its note and annotation content. Since this is evaluated before the system was laid out, the system did not have pointers to its SpannerSegments. This commit adds a way to include whether a staff has any spanners (particularly pedal markings and hanging slurs) in assessing emptiness, creating more consistent/expected hiding behavior in HideMode::AUTO. Port of musescore#8430, part 2

iveshenry18 added 2 commits June 24, 2021 19:51

oktophonie approved these changes Jun 25, 2021

View reviewed changes

vpereverzev approved these changes Jun 28, 2021

View reviewed changes

vpereverzev merged commit 0386b95 into musescore:3.6.2_backend Jun 28, 2021

Jojo-Schmitz mentioned this pull request Jun 29, 2021

[MU3 Issue] MuseScore 3.6.3 or 3.7.0, PRs to be merged and issues to be fixed. #7449

Closed

Jojo-Schmitz reviewed Jul 5, 2021

View reviewed changes

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 5, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

9ebf957

See musescore#8430 (review)

iveshenry18 mentioned this pull request Jul 5, 2021

[MU3 Backend] Tweak staff hiding conditions for spanners #8527

Merged

8 tasks

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 6, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

03ff5ef

See musescore#8430 (review)

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 13, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

93ade14

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

80e326b

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

ce901f7

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

3e8b376

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

fc42a5c

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz mentioned this pull request Sep 1, 2021

[MU3] Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 #9000

Closed

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

022c73a

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

2d7e866

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

9452836

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021

Fix for voltas and system text lines after "ENG-54, part 2"

41151b6

See musescore#8430 (review) and musescore#8527

Jojo-Schmitz mentioned this pull request Mar 1, 2023

Fix GH#7449: Almost everything suitable for 3.6.3 or 3.7.0 Jojo-Schmitz/MuseScore#80

Closed

Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023

Fix for voltas and system text lines after "ENG-54, part 2"

86d0397

See musescore#8430 (review) and musescore#8527

musescore deleted a comment from Jojo-Schmitz May 9, 2023

Jojo-Schmitz mentioned this pull request Oct 11, 2023

Staff visibility #19679

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[MU3 Backend] ENG-54: Staff Visibility #8430

[MU3 Backend] ENG-54: Staff Visibility #8430

iveshenry18 commented Jun 25, 2021

Jojo-Schmitz Jul 5, 2021 •

edited

Loading

iveshenry18 Jul 5, 2021

[MU3 Backend] ENG-54: Staff Visibility #8430

[MU3 Backend] ENG-54: Staff Visibility #8430

Conversation

iveshenry18 commented Jun 25, 2021

Jojo-Schmitz Jul 5, 2021 • edited Loading

Choose a reason for hiding this comment

iveshenry18 Jul 5, 2021

Choose a reason for hiding this comment

Jojo-Schmitz Jul 5, 2021 •

edited

Loading