Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-60: Move and hide additional fermatas #8509

Merged
merged 1 commit into from
Jul 7, 2021
Merged

[MU3 Backend] ENG-60: Move and hide additional fermatas #8509

merged 1 commit into from
Jul 7, 2021

Conversation

iveshenry18
Copy link
Contributor

Resolves: ENG-60: Correct position of pauses in two voices

When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@iveshenry18
ENG-60: Move and hide additional fermatas
937db1f 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jul 5, 2021
Closed
@vpereverzev vpereverzev merged commit 5511ad6 into musescore:3.6.2_backend Jul 7, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
b37f987 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
8eb309e 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
8a439c9 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
b80efc3 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
77d5628 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
e53f70a 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
c1f9655 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
6e8bff2 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
83af5c6 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
34264bb 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
690aaaa 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
38a04da 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
421f4bb 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
5d385f0 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
89a7e37 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
6283df7 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
0efebd2 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
d8e701d 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@iveshenry18 @Jojo-Schmitz
ENG-60: Move and hide additional fermatas
d7962ee 
When a fermata in a secondary voice is read, this commit adds handling
that moves it below the staff. Additionally, there is handling to hide
it if the duration of both voices is the same, or if there is also
already a fermata below the staff.

Duplicate of musescore#8509
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Aug 11, 2024
Merged
@Jojo-Schmitz
Copy link
Contributor

Jojo-Schmitz commented Aug 11, 2024 •
edited
Loading

If and when this one ever gets ported to current master, be aware of another needed change, see Jojo-Schmitz#570 and Jojo-Schmitz#571

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oktophonie oktophonie oktophonie approved these changes

@vpereverzev vpereverzev vpereverzev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@iveshenry18 @Jojo-Schmitz @oktophonie @vpereverzev