Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-57: Remove preliminary chord charts #8530

Merged
merged 1 commit into from
Jul 12, 2021
Merged

[MU3 Backend] ENG-57: Remove preliminary chord charts #8530

merged 1 commit into from
Jul 12, 2021

Conversation

iveshenry18
Copy link
Contributor

Resolves: ENG-57: Remove preliminary chord charts

Some PVG scores begin with a list of all chord charts for the piece.
These usually translate incorrectly to MusicXML; therefore, this commit
adds code to detect and remove these. In porting to master, perhaps this
code can be controlled with an import setting.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jul 6, 2021
Closed
@iveshenry18
ENG-57: Remove preliminary chord charts
3471114 
Some PVG scores begin with a list of all chord charts for the piece.
These usually translate incorrectly to MusicXML; therefore, this commit
adds code to detect and remove these. In porting to master, perhaps this
code can be controlled with an import setting.
@iveshenry18 iveshenry18 force-pushed the ENG-57-preliminary-chord-charts branch from 65826a5 to 3471114 Compare July 8, 2021 22:55
@vpereverzev vpereverzev merged commit 1d0957b into musescore:3.6.2_backend Jul 12, 2021
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@iveshenry18 @Jojo-Schmitz
ENG-57: Remove preliminary chord charts
6cea1a0 
Some PVG scores begin with a list of all chord charts for the piece.
These usually translate incorrectly to MusicXML; therefore, this commit
adds code to detect and remove these. In porting to master, perhaps this
code can be controlled with an import setting.

Duplicate of musescore#8530
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@iveshenry18 @Jojo-Schmitz
ENG-57: Remove preliminary chord charts
0bb60d2 
Some PVG scores begin with a list of all chord charts for the piece.
These usually translate incorrectly to MusicXML; therefore, this commit
adds code to detect and remove these. In porting to master, perhaps this
code can be controlled with an import setting.

Duplicate of musescore#8530
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@iveshenry18 @Jojo-Schmitz
ENG-57: Remove preliminary chord charts
6c5fd97 
Some PVG scores begin with a list of all chord charts for the piece.
These usually translate incorrectly to MusicXML; therefore, this commit
adds code to detect and remove these. In porting to master, perhaps this
code can be controlled with an import setting.

Duplicate of musescore#8530
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 22, 2022
Merged
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 23, 2022
@Jojo-Schmitz
Fix #330595: Crash on selecting entire score after XML import
80f251e 
Backport of musescore#10860, plus a fix on importing an empty XML file, which
apparently doesn't apply to master. For master it got fix in musescore#8200,
in 3.x it got fixed in musescore#8199, but broke again with the port of musescore#8530.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 23, 2022
@Jojo-Schmitz
Fix #330595: Crash on selecting entire score after XML import
03a453f 
Backport of musescore#10860, plus a fix on importing an empty XML file, which
apparently doesn't apply to master. For master it got fix in musescore#8200,
in 3.x it got fixed in musescore#8199, but broke again with the port of musescore#8530.
Converting some `foreach(..., ...)` into `for (... : ...)` along the way.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 24, 2022
@Jojo-Schmitz
Fix #330595: Crash on selecting entire score after XML import
0dcde3c 
Backport of musescore#10860, plus a fix on importing an empty XML file, which
apparently doesn't apply to master. For master it got fix in musescore#8200,
in 3.x it got fixed in musescore#8199, but broke again with the port of musescore#8530.
Converting some `foreach(..., ...)` into `for (... : ...)` along the way.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
@Jojo-Schmitz
Fix #330595: Crash on selecting entire score after XML import
4be2ddc 
Backport of musescore#10860, plus a fix on importing an empty XML file, which
apparently doesn't apply to master. For master it got fix in musescore#8200,
in 3.x it got fixed in musescore#8199, but broke again with the port of musescore#8530.
Converting some `foreach(..., ...)` into `for (... : ...)` along the way.
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@iveshenry18 @Jojo-Schmitz
ENG-57: Remove preliminary chord charts
a7faa1f 
Some PVG scores begin with a list of all chord charts for the piece.
These usually translate incorrectly to MusicXML; therefore, this commit
adds code to detect and remove these. In porting to master, perhaps this
code can be controlled with an import setting.

Duplicate of musescore#8530
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@Jojo-Schmitz
Fix #330595: Crash on selecting entire score after XML import
858d92c 
Backport of musescore#10860, plus a fix on importing an empty XML file, which
apparently doesn't apply to master. For master it got fix in musescore#8200,
in 3.x it got fixed in musescore#8199, but broke again with the port of musescore#8530.
Converting some `foreach(..., ...)` into `for (... : ...)` along the way.
This was referenced Apr 17, 2024
Merged
Merged
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 24, 2024
@Jojo-Schmitz
Fix mtests
2b024eb 
2 of which came in via a backport of musescore#8530, and havn't yet been ported to Mu4.
The other 2 don't exist in Mu4 either.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 24, 2024
@Jojo-Schmitz
Fix mtests
c30059e 
2 of which came in via a backport of musescore#8530, the other 2 came in via a backport of musescore#8311 and musescore#8116, apparenrly neither have yet been ported to Mu4.
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jun 12, 2024
@Jojo-Schmitz
Fix mtests
35fb5e5 
2 of which came in via a backport of musescore#8530, the other 2 came in via a backport of musescore#8311 and musescore#8116, apparenrly neither have yet been ported to Mu4.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vpereverzev vpereverzev vpereverzev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iveshenry18 @vpereverzev