-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU3 Backend] ENG-64: Fix layout overflows in XML import #8613
Merged
vpereverzev
merged 1 commit into
musescore:3.6.2_backend
from
iveshenry18:ENG-64-system-overflow
Jul 28, 2021
Merged
[MU3 Backend] ENG-64: Fix layout overflows in XML import #8613
vpereverzev
merged 1 commit into
musescore:3.6.2_backend
from
iveshenry18:ENG-64-system-overflow
Jul 28, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iveshenry18
changed the title
ENG-64: Fix layout overflows in XML import
[MU3 Backend] ENG-64: Fix layout overflows in XML import
Jul 15, 2021
oktophonie
approved these changes
Jul 15, 2021
vpereverzev
approved these changes
Jul 20, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted.
iveshenry18
force-pushed
the
ENG-64-system-overflow
branch
from
July 20, 2021 20:39
f85084e
to
19e59b4
Compare
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Jul 28, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 13, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 19, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Aug 30, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 1, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 2, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 4, 2021
See musescore#8613 Not sure why this is needed all of a sudden?
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 6, 2021
See musescore#8613 Not sure why this is needed all of a sudden?
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 9, 2021
See musescore#8613 Not sure why this is needed all of a sudden?
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 10, 2021
See musescore#8613 Not sure why this is needed all of a sudden?
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
See musescore#8613 Not sure why this is needed all of a sudden?
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 24, 2021
See musescore#8613 Not sure why this is needed all of a sudden?
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2021
See musescore#8613 Not sure why this is needed all of a sudden?
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 29, 2021
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 29, 2021
See musescore#8613 Not sure why this is needed all of a sudden?
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
See musescore#8613 Not sure why this is needed all of a sudden?
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Due to differences in how spacing is handled, some systems and pages overflow when importing an XML with system and page break information. This commit specifies tight measure spacing to the PVGMusicXML.mss, fixing many of these cases. Additionally, it adds a function to attempt reducing margins by 20% and lyric font size by 5% in order to eliminate any remaining overflows. If the overflows aren't eliminated, the changes are reverted. Duplicate of musescore#8613
Jojo-Schmitz
added a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
See musescore#8613 Not sure why this is needed all of a sudden?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: ENG-64: Systems overflow and cause page layout issues
Due to differences in how spacing is handled, some systems and pages
overflow when importing an XML with system and page break information.
This commit specifies tight measure spacing to the PVGMusicXML.mss,
fixing many of these cases. Additionally, it adds a function to attempt
reducing margins by 20% and lyric font size by 5% in order to eliminate
any remaining overflows. If the overflows aren't eliminated, the changes
are reverted.