Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MU3 Backend] ENG-70: Tweak default-y handling #8649

Merged
merged 1 commit into from
Jul 20, 2021
Merged

[MU3 Backend] ENG-70: Tweak default-y handling #8649

merged 1 commit into from
Jul 20, 2021

Conversation

iveshenry18
Copy link
Contributor

Resolves: ENG-70: Default-y ordering fails when there are multiple words in a direction or there is an offset

Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@iveshenry18
ENG-70: Tweak default-y handling
117c8f3 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Jul 17, 2021
Closed
@vpereverzev vpereverzev merged commit c5f41ee into musescore:3.6.2_backend Jul 20, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 21, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
cc8919f 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
8fd1b5d 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
421638a 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
6ee4b24 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
50d1701 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
bf202a6 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 27, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
dc54d16 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
4bd7bd5 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Jul 28, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
e3a7a24 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
cd77762 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 13, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
064cdd6 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
20b5c68 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 19, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
041b076 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Aug 30, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
fa2ce8f 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Sep 1, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 1, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
053ed23 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 2, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
4155345 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 10, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
9ee7819 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Sep 23, 2021
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
49d4355 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
ab608d1 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@iveshenry18 @Jojo-Schmitz
ENG-70: Tweak default-y handling
f6b4244 
Previously, default-y handling failed for directions with multiple
words in some cases. This commit fixes that by prefering the first
non-zero default-y and relative-y values and preventing later words
from overwriting that. It also simplifies the use of _hasDefaultY and
_hasRelativeY.

Duplicate of musescore#8649
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oktophonie oktophonie oktophonie approved these changes

@vpereverzev vpereverzev vpereverzev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iveshenry18 @oktophonie @vpereverzev