-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed SMuFL anchors #8958
Fixed SMuFL anchors #8958
Conversation
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...)
What puzzles me is that there are no vtest differences reported? There should be some minor ones (but for the better) |
That makes me a little worried too, also because I remember a PR of yours for which we also expected vtest differences but there wasn't. Makes me wonder whether the vtests are working at all... |
Yes, #8853. Something about the vtests seems severly broken |
fe3ec20
to
4f21de3
Compare
It probably starts going wrong because the vtest input files are still old mscx files. It is unclear to me whether any output images are generated at all. Then the compare step silently fails:
Will try to fix it tomorrow. |
It is a separate issue though, not the business of this PR here. Which is good as it is, and should get merged sooner rather than later ;-) BTW: thanks for splitting off the unrelated changes into a separate commit, helps understanding what this is about. |
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Update musescorefonts-Petaluma.qrc, pretty bad ommission from musescore#5381 Backport of musescore#8958 (not a very straight one...), part 2 (part 1 doesn't apply here at all)
Resolves:
While working on #8952, I wrote some extra drawing code for debugging bboxes, positioning, anchors etc.. This revealed that the SMuFL anchors were hardly ever in the correct place, so stems were not attached correctly to noteheads. They always seemed to be at 80% of their correct position from the origin. And exactly that was the case. Now it looks like this:
(red
+
means origin of element; orange+
is flag anchor point; yellow+
is notehead anchor point; the green rect is the bounding box. Please don't mind the badly-placed and purple-coloured stems in this picture.)Here is it without those extra things:
It also turned out that the metadata file for Petaluma was not added to the application, so for Petaluma the anchors did not work at all. That's fixed too with this PR.