fix edge case from #9086, inner hidden staves affect bracket span #9140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 16, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 16, 2021
Backport of musescore#9140, follow up for musescore#9086
|
Checked #9140 on Win10, Mac10.15.7, Linux Mint 20.2 - FIXED Please promote to master |
RomanPudashkin
approved these changes
Sep 16, 2021
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 17, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 20, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 21, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 22, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 23, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 24, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 26, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Sep 29, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Oct 3, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Dec 7, 2021
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
May 12, 2022
Backport of musescore#9140, follow up for musescore#9086
Jojo-Schmitz
pushed a commit
to Jojo-Schmitz/MuseScore
that referenced
this pull request
Mar 5, 2023
Backport of musescore#9140, follow up for musescore#9086
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #9086 was merged, @DmitryArefiev pointed out a bug in the implimentation:
#9086 (comment)
The original PR was to select correct brace symbol for each system independently. This mean that hidden staves should not affect bracket size. The original PR worked when outer staves were hidden, but not inner staves.
This PR resolves that bug such that hidden inner staves don't affect bracket size.
Tested this PR with the following file: bracket-staves.mscz.zip