-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consistent system left alignment #9277
Consistent system left alignment #9277
Conversation
Looks like the macOS build failed on CI. Looking at the details, it seems like the test setup failed, not the build itself. I can confirm on my MacBook Pro that this builds successfully on macOS. |
1e6ae77
to
c9317e5
Compare
Noticed that @Jojo-Schmitz created a PR yesterday to fix the CI build issue on macOS. Rebased this PR to hopefully resolve this failed CI check. Edit: It passes now! |
That fix of mine was unrelated though. |
Ok. Well, the rebasing worked anyways. |
c9317e5
to
fecdbed
Compare
Remove unused code path fix codestyle
fecdbed
to
d9b54c1
Compare
Resolves: #8968
Here's a brief overview:
instrumentNameOffset
, which removes a fewTODO
items from the codealignSystemToMargin
More details can be found in the issue itself.