Added the possibility to use straight flags #9307
Conversation
cbjeukendrup
force-pushed
the
straight_flags
branch
from
59bd18c
to
b25ca93
Compare
| @@ -6015,6 +6032,23 @@ constexpr const std::array<const char*, size_t(SymId::lastSym) + 1> SymNames::s_ | |||
| "Large brace", | |||
| "Larger brace", | |||
|
|
|||
| "Combining flag 8 (1024th) below straight", | |||
There was a problem hiding this comment.
Translatability of those would be needed, now that they became '1st class citizen'
There was a problem hiding this comment.
Why would that be needed? As far as I know, these names are never exposed in the UI. The only reason that I added them, is to make sure that the lists of names stay consistent.
By the way, the names of the normal flags are not translated either. If the names for the straight flags need to be translatable, shouldn’t those for the normal ones be too?
There was a problem hiding this comment.
These names are exposed, at least in the Symbols palette of the master palette. But indeed if the normal flags ain't, these don't need it either, so sorry for the noise.
|
Later today, I will implement that the Shadow Note follows the style of the score. |
cbjeukendrup
force-pushed
the
straight_flags
branch
from
b25ca93
to
8daba1a
Compare
cbjeukendrup
force-pushed
the
straight_flags
branch
from
8daba1a
to
caddac2
Compare
StraightNoteFlags.mov
Note: currently, it is broken when using Leland, because the metadata file for Leland needs to be fixed, but @oktophonie is working on that.
For fonts that do not support straight flags, Bravura is used as a fallback. (We may choose to implement a fallback chain, so that MuseScore first tries the font the user specified, then Leland, then Bravura.)