Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU3] Use symbol fonts for dynamics or tempo symbols / Let dynamic/tempo symbols auto-resize to surrounding text #9387

Closed
wants to merge 3 commits into from

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Oct 6, 2021

Backport of #9359, #9395 and #9427, and only/mainly to get the vtests to run (which are expected to fail)

@Jojo-Schmitz Jojo-Schmitz force-pushed the dynamic-fonts-3.c branch 2 times, most recently from bd31e55 to 1c036d5 Compare October 8, 2021 10:51
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Oct 8, 2021

As expected the vtests fail, but in a way that is not expected at all.
I don't understand why this doesn't seem to work at all, it seems as it weren't possible in 3.x to use a MusicalSymbolFont for text?
At least not for scores from 2.x?

@Jojo-Schmitz Jojo-Schmitz changed the title [MU3] Use symbol fonts for dynamics or tempo symbols [MU3] Use symbol fonts for dynamics or tempo symbols / Let dynamic/tempo symbols auto-resize to surrounding text Oct 9, 2021
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Nov 30, 2021

No longer needed, now that a) the vtests on master work and b) 2 of these 3 PRs are merged

@Jojo-Schmitz Jojo-Schmitz deleted the dynamic-fonts-3.c branch November 30, 2021 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants