-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #9514: only apply text to the first element in range selections #9532
Fix #9514: only apply text to the first element in range selections #9532
Conversation
Make sure you don't break the case of selections across multiple staves - you need to be sure to add to the first note of each. |
…e beginning of each staff
@MarcSabatella Good point, I added it back. Now, it will add the text to the first element of each selected staff. |
Backport of musescore#9532. Todo: attribuite it to @martin-danhier
Backport of musescore#9532. Todo: attribuite it to @martin-danhier
@martin-danhier Great job! It looks much better then it was. Thanks! But one question.. Is it hard to add dynamic this way (to each first note)? |
That's why the fix is called: First element is not first note. |
@DmitryArefiev That's right, I considered the first element, which is always at the start of the selection. Though, I could change that to the first note if this is how we want it to behave. But then, I would need more details, for example what happens if a selected staff doesn't have any note on it? Does this behavior only apply to dynamics, or all types of text ? If we choose not to do that, I'll change the comment as @Jojo-Schmitz suggested. By the way, how do you create GIFs like that ? ^^ |
Nice as it might be in this particular case to have dynamics be smart enough to apply the first note rather than first element (technically, first chordrest), I think that's going too far. My expectation is that it is my responsibility to make the selection match my needs, and if that means Ctrl+click to add "staggered" dynamics like this, so be it. Because there are any number of other markings I might want to apply to the first note or rest (eg, a custom staff text I've created and added to my palette). Although I guess it wouldn't hurt to add the additional smarts for dynamics to skip rests. Really, it's a very nice idea, just somehow seems possibly a little too smart if such a thing is possible! |
@martin-danhier Yeah, let's leave it as it is now (add dynamic/text to the first element of range selection).
Oh, it's recordit app (https://recordit.co/)
Good. After that the PR can be merged. Thanks! |
Backport of musescore#9532. Todo: attribute it to @martin-danhier
Backport of musescore#9532. Todo: attribute it to @martin-danhier
Backport of musescore#9532. Todo: attribute it to @martin-danhier
Backport of musescore#9532. Todo: attribute it to @martin-danhier
Backport of musescore#9532. Todo: attribute it to @martin-danhier
Resolves: #9514
When a text is added to a range selection, the text will be added to the first element instead of each one.
This works for any subtype of
TextBase
so it includes staff text, system text, expression, dynamics...Before:
before.mp4
After:
after.mp4