Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #9444 key signature mode property update process #9706

Merged
merged 1 commit into from
Nov 15, 2021
Merged

Fix #9444 key signature mode property update process #9706

merged 1 commit into from
Nov 15, 2021

Conversation

LovCAPONE
Copy link
Contributor

Resolves: #9444

Update the staff's key signature associated with the key signature
selected in the Inspector whenever a property is modified.

The problem is that whenever the user changes the key signature mode
property in the Inspector, the value in the staff's key signature at
this tick is not updated. So, in the score update process when the key
signature mode is fetched the value returned is the default key
signature mode.

  • I signed CLA
  • I made sure the code in the PR follows the coding rules
  • I made sure the code compiles on my machine
  • I made sure there are no unnecessary changes in the code
  • I made sure the title of the PR reflects the core meaning of the issue you are solving
  • I made sure the commit message(s) contain a description and answer the question "Why do those changes fix that particular issue?" or "Why are those changes really necessary as improvements?"
  • I made sure the commit message title starts with "fix #424242:" if there is a related issue
  • I created the test (mtest, vtest, script test) to verify the changes I made

@LovCAPONE
Fix musescore#9444 key signature mode property update process
b836407 
Update the staff's key signature associated with the key signature
selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the
score containing the property's element is updated. For the key
signature mode property, in the score update process the current
key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode
property in the Inspector, the value in the staff's key signature at
this tick is not updated. So, in the score update process when the key
signature mode is fetched the value returned is the default key
signature mode.

Fix musescore#9444
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Nov 11, 2021
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 11, 2021
@LovCAPONE @Jojo-Schmitz
Fix #304086, GH#9444: Key signature mode property update process
56de186 
Update the staff's key signature associated with the key signature selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the score containing the property's element is updated. For the key signature mode property, in the score update process the current key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode property in the Inspector, the value in the staff's key signature at this tick is not updated. So, in the score update process when the key signature mode is fetched the value
returned is the default key signature mode.

Backport of musescore#9706
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 13, 2021
@LovCAPONE @Jojo-Schmitz
Fix #304086, GH#9444: Key signature mode property update process
cb15439 
Update the staff's key signature associated with the key signature selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the score containing the property's element is updated. For the key signature mode property, in the score update process the current key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode property in the Inspector, the value in the staff's key signature at this tick is not updated. So, in the score update process when the key signature mode is fetched the value
returned is the default key signature mode.

Backport of musescore#9706
@LovCAPONE
Copy link
Contributor Author

@Jojo-Schmitz This PR is ready for review.

@Jojo-Schmitz
Copy link
Contributor

It is fine by me and does indeed fix the issue.

@RomanPudashkin RomanPudashkin merged commit b79fa05 into musescore:master Nov 15, 2021
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 23, 2021
@LovCAPONE @Jojo-Schmitz
Fix #304086, GH#9444: Key signature mode property update process
5f09857 
Update the staff's key signature associated with the key signature selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the score containing the property's element is updated. For the key signature mode property, in the score update process the current key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode property in the Inspector, the value in the staff's key signature at this tick is not updated. So, in the score update process when the key signature mode is fetched the value
returned is the default key signature mode.

Backport of musescore#9706
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 24, 2021
@LovCAPONE @Jojo-Schmitz
Fix #304086, GH#9444: Key signature mode property update process
ae007ea 
Update the staff's key signature associated with the key signature selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the score containing the property's element is updated. For the key signature mode property, in the score update process the current key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode property in the Inspector, the value in the staff's key signature at this tick is not updated. So, in the score update process when the key signature mode is fetched the value
returned is the default key signature mode.

Backport of musescore#9706
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 28, 2021
@LovCAPONE @Jojo-Schmitz
Fix #304086, GH#9444: Key signature mode property update process
0a323de 
Update the staff's key signature associated with the key signature selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the score containing the property's element is updated. For the key signature mode property, in the score update process the current key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode property in the Inspector, the value in the staff's key signature at this tick is not updated. So, in the score update process when the key signature mode is fetched the value
returned is the default key signature mode.

Backport of musescore#9706
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 28, 2021
@LovCAPONE @Jojo-Schmitz
Fix #304086, GH#9444: Key signature mode property update process
feba735 
Update the staff's key signature associated with the key signature selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the score containing the property's element is updated. For the key signature mode property, in the score update process the current key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode property in the Inspector, the value in the staff's key signature at this tick is not updated. So, in the score update process when the key signature mode is fetched the value
returned is the default key signature mode.

Backport of musescore#9706
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 30, 2021
@LovCAPONE @Jojo-Schmitz
Fix #304086, GH#9444: Key signature mode property update process
2de14fc 
Update the staff's key signature associated with the key signature selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the score containing the property's element is updated. For the key signature mode property, in the score update process the current key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode property in the Inspector, the value in the staff's key signature at this tick is not updated. So, in the score update process when the key signature mode is fetched the value
returned is the default key signature mode.

Backport of musescore#9706
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 7, 2021
@LovCAPONE @Jojo-Schmitz
Fix #304086, GH#9444: Key signature mode property update process
c41d407 
Update the staff's key signature associated with the key signature selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the score containing the property's element is updated. For the key signature mode property, in the score update process the current key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode property in the Inspector, the value in the staff's key signature at this tick is not updated. So, in the score update process when the key signature mode is fetched the value
returned is the default key signature mode.

Backport of musescore#9706
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request May 12, 2022
@LovCAPONE @Jojo-Schmitz
Fix #304086, GH#9444: Key signature mode property update process
6fe203c 
Update the staff's key signature associated with the key signature selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the score containing the property's element is updated. For the key signature mode property, in the score update process the current key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode property in the Inspector, the value in the staff's key signature at this tick is not updated. So, in the score update process when the key signature mode is fetched the value
returned is the default key signature mode.

Backport of musescore#9706
@Jojo-Schmitz Jojo-Schmitz mentioned this pull request Mar 1, 2023
Closed
Jojo-Schmitz pushed a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@LovCAPONE @Jojo-Schmitz
Fix #304086, GH#9444: Key signature mode property update process
994715d 
Update the staff's key signature associated with the key signature selected in the Inspector whenever a property is modified.

Whenever the value of a property of the Inspector changes, the score containing the property's element is updated. For the key signature mode property, in the score update process the current key signature mode is fetched from the staff's key signature list.
Then, the key signature mode property is updated with this value.

The problem is that whenever the user changes the key signature mode property in the Inspector, the value in the staff's key signature at this tick is not updated. So, in the score update process when the key signature mode is fetched the value
returned is the default key signature mode.

Backport of musescore#9706
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jojo-Schmitz Jojo-Schmitz Jojo-Schmitz approved these changes

@RomanPudashkin RomanPudashkin RomanPudashkin approved these changes

Assignees

@DmitryArefiev DmitryArefiev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LovCAPONE @Jojo-Schmitz @RomanPudashkin @DmitryArefiev