Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MU4] Fix #321771: Adding new SMuFL glyphs to MuseScore notehead library #9805

Merged
merged 1 commit into from
Apr 26, 2023

Conversation

Jojo-Schmitz
Copy link
Contributor

@Jojo-Schmitz Jojo-Schmitz commented Nov 20, 2021

@Jojo-Schmitz Jojo-Schmitz marked this pull request as draft November 20, 2021 19:35
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 21, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 21, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 21, 2021
@Jojo-Schmitz Jojo-Schmitz force-pushed the noteheads branch 2 times, most recently from 19eb873 to 552a0b4 Compare November 21, 2021 09:54
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 21, 2021
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Nov 21, 2021

OK, they did show under "Notehead group", now also under "Custom"/"Edit Noteheads"

Additional difficulty: these 4 "Techniques noteheads" all come with a (short and up) stem and in the case of the "Swiss rudiments doublé" noteheads with a flag too, so the 'normal' stem, flag and beam would need to get disabled somehow.

Also unclear: whether and how to im- and/or export from/to MusicXML

@Jojo-Schmitz Jojo-Schmitz force-pushed the noteheads branch 3 times, most recently from b0f0ac2 to 072fe3f Compare November 21, 2021 13:30
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 21, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 23, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 24, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 24, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 24, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 26, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 28, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 28, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Nov 30, 2021
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Dec 7, 2021
@Jojo-Schmitz
Copy link
Contributor Author

Jojo-Schmitz commented Dec 28, 2021

Reg. MusicXML export (and import?), see https://musescore.org/en/node/321771#comment-1109492:

if the notehead type is a non-standard shape not listed in the notehead-value table but with a defined SMuFL notehead glyph, encode as a notehead element with content "other" and an attribute "smufl" specifying the SMuFL canonical glyph name. For the new glyphs, the names would be: swissRudimentsNoteheadBlackFlam, swissRudimentsNoteheadHalfFlam, swissRudimentsNoteheadBlackDouble and swissRudimentsNoteheadHalfDouble (https://w3c.github.io/smufl/releases/1.4/tables/techniques-noteheads.html).

@Jojo-Schmitz Jojo-Schmitz force-pushed the noteheads branch 2 times, most recently from c247385 to fe1c668 Compare August 1, 2022 08:50
@cbjeukendrup cbjeukendrup added the strings Affects translatable strings label Sep 26, 2022
Jojo-Schmitz added a commit to Jojo-Schmitz/MuseScore that referenced this pull request Mar 5, 2023
@ursgehrig
Copy link

Dear Jojo, thank you a lot for adding this commit regarding Fix #321771. Kindest, Urs

@randombenj
Copy link

@Jojo-Schmitz @ursgehrig Nice to see your efforts for the Swiss Drumming community 😄 🎉

I just built v4.0.2 from source, cherry-picking your commit @Jojo-Schmitz it works like a charm:

image
image

I am also currently creating a custom soundfont for rudimental drumming to have sound on both left and right sticks as
they have different pitches. So using the new font flam sounds could also be added to this soundfont.

Are there any plans to merge this soon @Jojo-Schmitz as this MR has been open for quite some time I see.
Let me know if there is anything I could help with.

Cheers, Benj

@Jojo-Schmitz
Copy link
Contributor Author

It's not up to me to make the decision to merge this PR, but I'll mark it ready for review and will rebase it

@Jojo-Schmitz Jojo-Schmitz marked this pull request as ready for review April 3, 2023 15:34
@randombenj
Copy link

Perfect, thank you! As mentioned for anyone reviewing this change, this would enable us to annotate flams and doublé in swiss drumming style notation. So merging this would be highly appreciated :)

@RomanPudashkin RomanPudashkin merged commit 9b4a942 into musescore:master Apr 26, 2023
@Jojo-Schmitz Jojo-Schmitz deleted the noteheads branch April 26, 2023 09:01
@musescore musescore deleted a comment from randombenj Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
strings Affects translatable strings
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants