-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MU4] Fix #321771: Adding new SMuFL glyphs to MuseScore notehead library #9805
Conversation
a648b49
to
7fca747
Compare
19eb873
to
552a0b4
Compare
552a0b4
to
5a4ec47
Compare
OK, they did show under "Notehead group", now also under "Custom"/"Edit Noteheads" Additional difficulty: these 4 "Techniques noteheads" all come with a (short and up) stem and in the case of the "Swiss rudiments doublé" noteheads with a flag too, so the 'normal' stem, flag and beam would need to get disabled somehow. Also unclear: whether and how to im- and/or export from/to MusicXML |
b0f0ac2
to
072fe3f
Compare
072fe3f
to
5f4a2bf
Compare
5f4a2bf
to
e757a4f
Compare
Reg. MusicXML export (and import?), see https://musescore.org/en/node/321771#comment-1109492: if the notehead type is a non-standard shape not listed in the notehead-value table but with a defined SMuFL notehead glyph, encode as a notehead element with content "other" and an attribute "smufl" specifying the SMuFL canonical glyph name. For the new glyphs, the names would be: swissRudimentsNoteheadBlackFlam, swissRudimentsNoteheadHalfFlam, swissRudimentsNoteheadBlackDouble and swissRudimentsNoteheadHalfDouble (https://w3c.github.io/smufl/releases/1.4/tables/techniques-noteheads.html). |
c247385
to
fe1c668
Compare
Dear Jojo, thank you a lot for adding this commit regarding Fix #321771. Kindest, Urs |
@Jojo-Schmitz @ursgehrig Nice to see your efforts for the Swiss Drumming community 😄 🎉 I just built I am also currently creating a custom soundfont for rudimental drumming to have sound on both left and right sticks as Are there any plans to merge this soon @Jojo-Schmitz as this MR has been open for quite some time I see. Cheers, Benj |
It's not up to me to make the decision to merge this PR, but I'll mark it ready for review and will rebase it |
Perfect, thank you! As mentioned for anyone reviewing this change, this would enable us to annotate flams and doublé in swiss drumming style notation. So merging this would be highly appreciated :) |
Resolves: https://musescore.org/en/node/321771
Adding these: https://w3c.github.io/smufl/latest/tables/techniques-noteheads.html
See also w3c/smufl#118 (which resulted in their addition)