System time implementation #4
Conversation
src/lib.rs
Outdated
| @@ -50,6 +73,16 @@ mod reference { | |||
| pub fn get_time() -> Duration { | |||
| *TIME.get_or_init(Mutex::default).lock().unwrap() | |||
| } | |||
|
|
|||
| pub fn get_time() -> Duration { | |||
There was a problem hiding this comment.
there are two get_time functions here. I assume one will alias the other.
src/lib.rs
Outdated
| pub struct SystemTime(Duration); | ||
|
|
||
| impl SystemTime { | ||
| pub const UNIX_EPOCH: SystemTime = SystemTime(Duration::from_secs(0)); |
There was a problem hiding this comment.
Being inside the struct prevents me from accessing it via use the way I access std::time::UNIX_EPOCH;
I worked around it with
#[cfg(test)]
const UNIX_EPOCH: SystemTime = SystemTime::UNIX_EPOCH;
There was a problem hiding this comment.
Oh, one should be with_system_time. copy-pasted error (basically get-nnn is a read-only accessor, and with-nnn are a way to modify the value atomically)
There was a problem hiding this comment.
Being inside the struct prevents me from accessing it via
usethe way I access std::time::UNIX_EPOCH;I worked around it with
#[cfg(test)] const UNIX_EPOCH: SystemTime = SystemTime::UNIX_EPOCH;
Interesting, I didn't know UNIX_EPOCH was at the module level. std has the struct-level one aliased from the module level one. I added this in 07c1ab2
|
If everything looks good now, I'll merge and publish it. |
This is discussed in #3