Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo #261

Merged
merged 1 commit into from
Mar 2, 2022
Merged

Fix typo #261

merged 1 commit into from
Mar 2, 2022

Conversation

fracnesco
Copy link
Contributor

@fracnesco fracnesco commented Mar 1, 2022 •
edited
Loading

Fix typo in adding global effects hack

@telephon
Copy link
Contributor

telephon commented Mar 2, 2022

thank you!

@telephon telephon merged commit dcf2371 into musikinformatik:develop Mar 2, 2022
@ndr-brt
Copy link
Contributor

ndr-brt commented Mar 2, 2022

wait... what was the typo? I see only a different code formatting.
If the goal was to improve readability, I would have extracted the effect to a variable before adding it to the global effects

@fracnesco
Copy link
Contributor Author

@ndr-brt missing semicolon on line 31

@ndr-brt
Copy link
Contributor

ndr-brt commented Mar 2, 2022

yeah, missed that sorry 🥲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fracnesco @telephon @ndr-brt