-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension of API for specifying transcript variants #380
Comments
The scope currently seems to be limited to specific API calls and only to support this syntax as input, not for Mutalyzer to produce it. While this may very well be a good first step, I think eventually we would like to make this the preferred way of selecting a transcript, so I'll try to see this proposal in that context. |
That is correct. There are no RefSeq files which have more than one version of a certain transcript annotated. So we could make the version optional, or even disallow it. I can think of some up- and downsides to both approaches:
In my opinion the Also, if we choose to make the version optional, reusing Although these seem implementation details, I think it is important to think carefully about any BNF changes and naming of production rules. As you can see, the naming of
Yes, I would like to see a few tests, perhaps even start with those 👍
That is incorrect, here's an example of that. However, I think the only occurrences of this are mtDNA genes, since we don't have mappings for
I don't know, will have to try. |
Related, it is good to keep in mind that there can be transcripts annotated without an accession number. For this specific use case it will probably not matter, but this is probably enough reason to always keep supporting the old syntax. Also something to be aware of when we start to implement producing descriptions with this syntax, it will not always be possible. Here's a quick check I ran on our database. It seems that most transcripts are annotated with an accession, but not all. |
Please note that whereas it's important to be able to match the transcript correctly on the input so that we don't get unintended EREF errors, it's also needed for LOVD to get the output with the transcript information. We normally loop through the results, and look for the i001 matching the v001 number. So we'll need some way to get the correct result. Perhaps the webservice could include the v-numbers and transcript IDs like the website does on the name checker? |
Yes, exactly, and we don't want to need two webservice calls for each namechecker call... That's why we cache that ID, and only now we found out that it's not stable... |
A downside of using a version number is that you get multiple equivalent descriptions. |
@jfjlaros Only if we make it optional, but that is the same situation we already have for the main accession number. I would actually propose to make the version required, since this matches what is in the annotation. Also, we already have multiple equivalent descriptions from the transcript selection syntax, and this proposal adds at least one. |
There is an issue where clients of Mutalyzer's API may query Mutalyzer with outdated information regarding transcript variants. See for example LOVDnl/LOVD3#73
I have made a gist with a more elaborate description of the problem and proposal of a fix.
The text was updated successfully, but these errors were encountered: