Accept transcript accession number as transcript variant identifier. #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| for gene in self.geneList: | ||
| for transcript in gene.transcriptList: | ||
| if transcript.transcriptID == transcript_id: | ||
| return (gene.name, transcript.name) |
There was a problem hiding this comment.
Can do without parentheses.
|
In addition to the line notes, could you squash and rebase on master? Let me know if you need a hint on how to do that. Overall 👍 |
mkroon1
force-pushed
the
accno-transcript-variant
branch
from
c3c0bd7
to
55bc10f
Compare
mkroon1
added a commit
that referenced
this pull request
Jun 15, 2016
* Internally the accession number is translated to the transcript name (i.e. v-number) and subsequent processing is untouched. Added failing test with accession number as transcript variant identifier. Fixed comments by @martijnvermaat in PR #405
|
Handled most of your comments, but did not make any changes to the grammar file. |
* Added failing test with accession number as transcript variant identifier. * Internally the accession number is translated to the transcript name (i.e. v-number) and subsequent processing is untouched.
martijnvermaat
force-pushed
the
accno-transcript-variant
branch
from
55bc10f
to
81b2120
Compare
|
Perfect, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Together with PR #404, this would fix the issue outlined in #380.
Fixes #380