Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug whereby ogg files would not be scanned #54

Merged
merged 1 commit into from
Feb 15, 2024
Merged

fix bug whereby ogg files would not be scanned #54

merged 1 commit into from
Feb 15, 2024

Conversation

waveyboym
Copy link
Member

Addresses a bug whereby ogg files would simply not be scanned even though they are supported by default.

  1. First id3 tries to scan
  2. If id3 fails, then lofty tries as a backup
  3. If lofty fails, then the file is either corrupt or not a music file at all

The functionality is still the same though.
ref: #53

@waveyboym waveyboym added bug Something isn't working fatal bug This bug is extremely fatal major-changes This pr includes major updates to the codebase labels Feb 15, 2024
@waveyboym waveyboym self-assigned this Feb 15, 2024
@waveyboym waveyboym merged commit 3ee7184 into main-app-dev Feb 15, 2024
@waveyboym waveyboym deleted the ogg-files-scan-fix branch February 15, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@waveyboym waveyboym

Labels
bug Something isn't working fatal bug This bug is extremely fatal major-changes This pr includes major updates to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@waveyboym