Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making seeker easier to use #7

Merged
merged 3 commits into from
Jan 23, 2024

Conversation

waveyboym
Copy link
Member

Changelog

  1. Adding volume parameter to SharedAudioManager to keep track of the audio volume level as kira does not have a get_volume() function.
  2. Added seek_by function exposed to the frontend. This function will allow seeking by a specified value, so if the value is 2secs, it will seek the playing position of a song 2secs ahead.
  3. Added a delay to seeking using the handle_true_seeking function. There are comments there that explain further the issues and the reasoning for why that function exists. The function can be found in player.rs

@waveyboym waveyboym added enhancement New feature or request backend-rust This pr involves backend rust code changes frontend-typescript This pr involves frontend typescript changes api changes This pr modifies backend exposed functions labels Jan 21, 2024
@waveyboym waveyboym self-assigned this Jan 21, 2024
@waveyboym waveyboym marked this pull request as ready for review January 23, 2024 11:13
@waveyboym waveyboym merged commit 94e0a48 into main-app-dev Jan 23, 2024
@waveyboym waveyboym deleted the making-seeker-easier-to-use-dev branch January 23, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api changes This pr modifies backend exposed functions backend-rust This pr involves backend rust code changes enhancement New feature or request frontend-typescript This pr involves frontend typescript changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant