Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing file reveal bug #8

Merged
merged 1 commit into from
Jan 23, 2024
Merged

fixing file reveal bug #8

merged 1 commit into from
Jan 23, 2024

Conversation

waveyboym
Copy link
Member

When a user chose to reveal a song when viewing it's properties, it would open the file with the default music app instead of revealing it in the file manager. The issue has now been addressed on windows and macos, however for linux based systems, since there is no universal command, the issue will remain unfixed. If a user using a linux based distro anticipates they will be using a specific file manager, they can build a binary with the specific name and command embedded into this file.

When a user chose to reveal a song when viewing it's properties, it would open the file with the default music app instead of revealing it in the file manager. The issue has now been addressed on windows and macos, however for linux based systems, since there is no universal command, the issue will remain unfixed.
If a user using a linux based distro anticipates they will be using a specific file manager, they can build a binary with the specific name and command embedded into this file.
@waveyboym waveyboym added backend-rust This pr involves backend rust code changes api changes This pr modifies backend exposed functions platform: macos Is related to macos platform: windows Is related to windows labels Jan 22, 2024
@waveyboym waveyboym self-assigned this Jan 22, 2024
@waveyboym waveyboym merged commit 5adbc7b into main-app-dev Jan 23, 2024
@waveyboym waveyboym deleted the file-reveal-bug-fix branch January 23, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api changes This pr modifies backend exposed functions backend-rust This pr involves backend rust code changes platform: macos Is related to macos platform: windows Is related to windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant