Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding rodio to music backend🎉 #86

Merged
merged 26 commits into from
Dec 5, 2024
Merged

Adding rodio to music backend🎉 #86

merged 26 commits into from
Dec 5, 2024

Conversation

waveyboym
Copy link
Member

@waveyboym waveyboym commented Dec 5, 2024 •
edited
Loading

Describe your changes

This PR introduces Rodio to the music backend 🎉 while retaining Kira for flexibility. Users can now switch between the two backends based on their preferences.

Key Features Added:

  1. Playback Speed Adjustment: Users can control the speed of audio playback.
  2. Output Device Selection: Available exclusively in Rodio, users can choose their desired output device for audio.
  3. Seamless Audio Transitions: Enjoy smooth fade-ins and fade-outs for a better listening experience.

Issue ticket number and link

Checklist before requesting a review

  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • Do we need to implement analytics?
  • Will this be part of a product update? If yes, please write one phrase about this update.
    Update Note: Introduces a dual music backend (Rodio and Kira) and enhances audio customization options.

@waveyboym
Merge pull request #48 from muzik-apps/main-app-dev
98a88b4 
bringing latest changes downstream
@waveyboym
Add AudioLab presets and WaveForm icon
d679b51
@waveyboym
Refactor convertToEnum function to use strict equality
e23adf6
@waveyboym
removing code causing merge conflict will re-add after merge
66644a0
@waveyboym
Merge pull request #50 from muzik-apps/main-app-dev
39841a4 
just bringing changes downstream
@waveyboym
Add AudioLab setting to convertToEnum function
a105571
@waveyboym
Update EqualizerSlider and AudioLabSettings styles
f840788
@waveyboym
Refactor AudioLabSettings component to add delete preset functionality
9d0f2be
@waveyboym
Merge branch 'main-app-dev' into equalizer-dev
23016bf
@waveyboym
Enhance EqualizerSlider styles: update range input appearance and cha…
d66c268 
…nge cursor to grab for better user interaction
@waveyboym
Merge pull request #81 from muzik-apps/main-app-dev
c721856 
Bringing changes downstream
@waveyboym
Add Kira and Rodio audio managers; refactor audio manager structure
0004bc6
@waveyboym
Add player selection to saved object and update invoke calls for play…
5ce967a 
…er context
@waveyboym
Merge branch 'adding-rodio-to-music-backend' into equalizer-dev
3e4934d
@waveyboym
Merge pull request #82 from muzik-apps/equalizer-dev
da25603 
Equalizer dev
@waveyboym
Add output device management functions to Rodio player
299193b
@waveyboym
Merge branch 'adding-rodio-to-music-backend' of https://github.com/mu…
6c4b879 
…zik-apps/muzik-offline into adding-rodio-to-music-backend
@waveyboym
Refactor appearance settings layout, add audio settings to saved obje…
5a68d87 
…ct, and implement output device management in Rodio player
@waveyboym
Update audio settings title to reflect audio quality options
e5d7fdd
@waveyboym
Add crossfade and duration properties to audio managers, update playb…
1bb0f53 
…ack functions to support playback speed and fade transitions
@waveyboym
Add duration parameter to song playback functions and update related …
14f092d 
…logic
@waveyboym
Merge pull request #85 from muzik-apps/working
98ee76b 
Bringing changes downstream
@waveyboym
Update .gitignore to exclude Python cache and executable files
9d2fbb2
@waveyboym
Merge branch 'adding-rodio-to-music-backend' of https://github.com/mu…
a8f5bad 
…zik-apps/muzik-offline into adding-rodio-to-music-backend
@waveyboym
Refactor dropdown menu styles and update AudioLabSettings layout for …
1e9e2b1 
…improved UI consistency
@waveyboym
Update Audio Lab header and refine dropdown menu styles for better UI…
8979d60 
… presentation
@waveyboym waveyboym added enhancement New feature or request backend-rust This pr involves backend rust code changes api changes This pr modifies backend exposed functions major-changes This pr includes major updates to the codebase labels Dec 5, 2024
@waveyboym waveyboym self-assigned this Dec 5, 2024
@waveyboym waveyboym merged commit f1be9a6 into working Dec 5, 2024
@waveyboym waveyboym deleted the adding-rodio-to-music-backend branch December 5, 2024 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@waveyboym waveyboym

Labels
api changes This pr modifies backend exposed functions backend-rust This pr involves backend rust code changes enhancement New feature or request major-changes This pr includes major updates to the codebase
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@waveyboym