Refactored Task to ValueTask (#51)

mvSapphire · Dec 10, 2023 · da96608 · da96608
1 parent e27ab9b
commit da96608
Show file tree

Hide file tree

Showing 39 changed files with 89 additions and 90 deletions.
diff --git a/samples/PowerPipe.Sample/SamplePipeline.cs b/samples/PowerPipe.Sample/SamplePipeline.cs
@@ -60,5 +60,5 @@ public class SamplePipelineContext : PipelineContext<SamplePipelineResult>
     public int Test1 { get; set; }
 
     public override SamplePipelineResult GetPipelineResult() => null;
-};
+}
 
diff --git a/samples/PowerPipe.Sample/Steps/SampleGenericStep.cs b/samples/PowerPipe.Sample/Steps/SampleGenericStep.cs
@@ -9,7 +9,7 @@ public class SampleGenericStep<T>: IPipelineStep<SamplePipelineContext>
 {
     public IPipelineStep<SamplePipelineContext> NextStep { get; set; }
 
-    public async Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public async ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleGenericStep<T>)} Executed");
         await NextStep.ExecuteAsync(context, cancellationToken);

diff --git a/samples/PowerPipe.Sample/Steps/SampleParallelStep1.cs b/samples/PowerPipe.Sample/Steps/SampleParallelStep1.cs
@@ -7,9 +7,9 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleParallelStep1 : IPipelineParallelStep<SamplePipelineContext>
 {
-    public Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleParallelStep1)} Executed");
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleParallelStep2.cs b/samples/PowerPipe.Sample/Steps/SampleParallelStep2.cs
@@ -7,9 +7,9 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleParallelStep2 : IPipelineParallelStep<SamplePipelineContext>
 {
-    public Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleParallelStep2)} Executed");
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleParallelStep3.cs b/samples/PowerPipe.Sample/Steps/SampleParallelStep3.cs
@@ -7,9 +7,9 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleParallelStep3 : IPipelineParallelStep<SamplePipelineContext>
 {
-    public Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleParallelStep3)} Executed");
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleParallelStep4.cs b/samples/PowerPipe.Sample/Steps/SampleParallelStep4.cs
@@ -7,12 +7,12 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleParallelStep4 : IPipelineParallelStep<SamplePipelineContext>
 {
-    public Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleParallelStep4)} Executed");
 
         throw new InvalidOperationException();
 
-        // return Task.CompletedTask;
+        // return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleParallelStep5.cs b/samples/PowerPipe.Sample/Steps/SampleParallelStep5.cs
@@ -7,12 +7,12 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleParallelStep5 : IPipelineParallelStep<SamplePipelineContext>
 {
-    public Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleParallelStep5)} Executed");
 
         // throw new InvalidOperationException();
 
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleParallelStep5Compensation.cs b/samples/PowerPipe.Sample/Steps/SampleParallelStep5Compensation.cs
@@ -7,9 +7,9 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleParallelStep5Compensation : IPipelineCompensationStep<SamplePipelineContext>
 {
-    public Task CompensateAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask CompensateAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleParallelStep5Compensation)} Executed");
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleParallelStep6.cs b/samples/PowerPipe.Sample/Steps/SampleParallelStep6.cs
@@ -7,9 +7,9 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleParallelStep6 : IPipelineParallelStep<SamplePipelineContext>
 {
-    public Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleParallelStep6)} Executed");
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleParallelStep7.cs b/samples/PowerPipe.Sample/Steps/SampleParallelStep7.cs
@@ -7,9 +7,9 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleParallelStep7 : IPipelineParallelStep<SamplePipelineContext>
 {
-    public Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleParallelStep7)} Executed");
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleStep1.cs b/samples/PowerPipe.Sample/Steps/SampleStep1.cs
@@ -8,9 +8,9 @@ namespace PowerPipe.Sample.Steps;
 public class SampleStep1 : IPipelineStep<SamplePipelineContext>
 {
     public IPipelineStep<SamplePipelineContext> NextStep { get; set; }
-    public async Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public async ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleStep1)} Executed");
         await NextStep.ExecuteAsync(context, cancellationToken);
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleStep1Compensation.cs b/samples/PowerPipe.Sample/Steps/SampleStep1Compensation.cs
@@ -7,9 +7,9 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleStep1Compensation : IPipelineCompensationStep<SamplePipelineContext>
 {
-    public Task CompensateAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask CompensateAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleStep1Compensation)} Executed");
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleStep2.cs b/samples/PowerPipe.Sample/Steps/SampleStep2.cs
@@ -8,9 +8,9 @@ namespace PowerPipe.Sample.Steps;
 public class SampleStep2 : IPipelineStep<SamplePipelineContext>
 {
     public IPipelineStep<SamplePipelineContext> NextStep { get; set; }
-    public async Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public async ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleStep2)} Executed");
         await NextStep.ExecuteAsync(context, cancellationToken);
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleStep2Compensation.cs b/samples/PowerPipe.Sample/Steps/SampleStep2Compensation.cs
@@ -7,9 +7,9 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleStep2Compensation : IPipelineCompensationStep<SamplePipelineContext>
 {
-    public Task CompensateAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask CompensateAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleStep2Compensation)} Executed");
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleStep3.cs b/samples/PowerPipe.Sample/Steps/SampleStep3.cs
@@ -8,9 +8,9 @@ namespace PowerPipe.Sample.Steps;
 public class SampleStep3 : IPipelineStep<SamplePipelineContext>
 {
     public IPipelineStep<SamplePipelineContext> NextStep { get; set; }
-    public async Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public async ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleStep3)} Executed");
         await NextStep.ExecuteAsync(context, cancellationToken);
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleStep4.cs b/samples/PowerPipe.Sample/Steps/SampleStep4.cs
@@ -8,9 +8,9 @@ namespace PowerPipe.Sample.Steps;
 public class SampleStep4 : IPipelineStep<SamplePipelineContext>
 {
     public IPipelineStep<SamplePipelineContext> NextStep { get; set; }
-    public async Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public async ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleStep4)} Executed");
         await NextStep.ExecuteAsync(context, cancellationToken);
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleStep5.cs b/samples/PowerPipe.Sample/Steps/SampleStep5.cs
@@ -8,9 +8,9 @@ namespace PowerPipe.Sample.Steps;
 public class SampleStep5 : IPipelineStep<SamplePipelineContext>
 {
     public IPipelineStep<SamplePipelineContext> NextStep { get; set; }
-    public async Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public async ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleStep5)} Executed");
         await NextStep.ExecuteAsync(context, cancellationToken);
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleStep6.cs b/samples/PowerPipe.Sample/Steps/SampleStep6.cs
@@ -8,9 +8,9 @@ namespace PowerPipe.Sample.Steps;
 public class SampleStep6 : IPipelineStep<SamplePipelineContext>
 {
     public IPipelineStep<SamplePipelineContext> NextStep { get; set; }
-    public async Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public async ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleStep6)} Executed");
         await NextStep.ExecuteAsync(context, cancellationToken);
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleStep7.cs b/samples/PowerPipe.Sample/Steps/SampleStep7.cs
@@ -8,12 +8,12 @@ namespace PowerPipe.Sample.Steps;
 public class SampleStep7 : IPipelineStep<SamplePipelineContext>
 {
     public IPipelineStep<SamplePipelineContext> NextStep { get; set; }
-    public async Task ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public async ValueTask ExecuteAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleStep7)} Executed");
 
         // throw new InvalidOperationException();
 
         await NextStep.ExecuteAsync(context, cancellationToken);
     }
-}
+}
diff --git a/samples/PowerPipe.Sample/Steps/SampleStep7Compensation.cs b/samples/PowerPipe.Sample/Steps/SampleStep7Compensation.cs
@@ -7,9 +7,9 @@ namespace PowerPipe.Sample.Steps;
 
 public class SampleStep7Compensation : IPipelineCompensationStep<SamplePipelineContext>
 {
-    public Task CompensateAsync(SamplePipelineContext context, CancellationToken cancellationToken)
+    public ValueTask CompensateAsync(SamplePipelineContext context, CancellationToken cancellationToken)
     {
         Console.WriteLine($"{nameof(SampleStep7Compensation)} Executed");
-        return Task.CompletedTask;
+        return ValueTask.CompletedTask;
     }
-}
+}
diff --git a/src/PowerPipe/Builder/Steps/AddIfElseStep.cs b/src/PowerPipe/Builder/Steps/AddIfElseStep.cs
@@ -34,7 +34,7 @@ internal AddIfElseStep(Predicate<TContext> predicate, IPipelineStep<TContext> if
     /// <param name="context">The context on which the if-else step operates.</param>
     /// <param name="cancellationToken">A cancellation token to cancel the operation.</param>
     /// <returns>A task representing the asynchronous operation.</returns>
-    protected override async Task ExecuteInternalAsync(TContext context, CancellationToken cancellationToken)
+    protected override async ValueTask ExecuteInternalAsync(TContext context, CancellationToken cancellationToken)
     {
         StepExecuted = true;
 
@@ -51,4 +51,4 @@ protected override async Task ExecuteInternalAsync(TContext context, Cancellatio
             await _elseStep.ExecuteAsync(context, cancellationToken);
         }
     }
-}
+}
diff --git a/src/PowerPipe/Builder/Steps/AddIfStep.cs b/src/PowerPipe/Builder/Steps/AddIfStep.cs
@@ -31,7 +31,7 @@ internal AddIfStep(Predicate<TContext> predicate, IPipelineStep<TContext> step)
     /// <param name="context">The context on which the if step operates.</param>
     /// <param name="cancellationToken">A cancellation token to cancel the operation.</param>
     /// <returns>A task representing the asynchronous operation.</returns>
-    protected override async Task ExecuteInternalAsync(TContext context, CancellationToken cancellationToken)
+    protected override async ValueTask ExecuteInternalAsync(TContext context, CancellationToken cancellationToken)
     {
         if (_predicate(context))
         {
@@ -47,4 +47,4 @@ protected override async Task ExecuteInternalAsync(TContext context, Cancellatio
                 await NextStep.ExecuteAsync(context, cancellationToken);
         }
     }
-}
+}
diff --git a/src/PowerPipe/Builder/Steps/CompensationStep.cs b/src/PowerPipe/Builder/Steps/CompensationStep.cs
@@ -29,7 +29,7 @@ internal CompensationStep(Func<IPipelineCompensationStep<TContext>> factory)
     }
 
     /// <inheritdoc/>
-    public async Task CompensateAsync(TContext context, CancellationToken cancellationToken)
+    public async ValueTask CompensateAsync(TContext context, CancellationToken cancellationToken)
     {
         IsCompensated = true;
 

diff --git a/src/PowerPipe/Builder/Steps/IfPipelineStep.cs b/src/PowerPipe/Builder/Steps/IfPipelineStep.cs
@@ -33,7 +33,7 @@ public IfPipelineStep(Predicate<TContext> predicate, PipelineBuilder<TContext, T
     /// <param name="context">The context on which the conditional pipeline step operates.</param>
     /// <param name="cancellationToken">A cancellation token to cancel the operation.</param>
     /// <returns>A task representing the asynchronous operation.</returns>
-    protected override async Task ExecuteInternalAsync(TContext context, CancellationToken cancellationToken)
+    protected override async ValueTask ExecuteInternalAsync(TContext context, CancellationToken cancellationToken)
     {
         if (_predicate(context))
         {
@@ -45,4 +45,4 @@ protected override async Task ExecuteInternalAsync(TContext context, Cancellatio
         if (NextStep is not null)
             await NextStep.ExecuteAsync(context, cancellationToken);
     }
-}
+}
diff --git a/src/PowerPipe/Builder/Steps/InternalStep.cs b/src/PowerPipe/Builder/Steps/InternalStep.cs
@@ -73,7 +73,7 @@ public void ConfigureErrorHandling(PipelineStepErrorHandling errorHandling, Time
     }
 
     /// <inheritdoc/>
-    public async Task ExecuteAsync(TContext context, CancellationToken cancellationToken)
+    public async ValueTask ExecuteAsync(TContext context, CancellationToken cancellationToken)
     {
         try
         {
@@ -107,16 +107,16 @@ public async Task ExecuteAsync(TContext context, CancellationToken cancellationT
     /// <param name="context">The context on which the step operates.</param>
     /// <param name="cancellationToken">A cancellation token to cancel the operation.</param>
     /// <returns>A task representing the asynchronous operation.</returns>
-    protected virtual Task ExecuteInternalAsync(TContext context, CancellationToken cancellationToken) =>
-        Task.CompletedTask;
+    protected virtual ValueTask ExecuteInternalAsync(TContext context, CancellationToken cancellationToken) =>
+        ValueTask.CompletedTask;
 
     /// <summary>
     /// Handles an exception that occurred during the step's execution.
     /// </summary>
     /// <param name="context">The context on which the step operates.</param>
     /// <param name="cancellationToken">A cancellation token to cancel the operation.</param>
     /// <returns>A task representing the asynchronous operation. Returns true if the exception is handled; otherwise, false.</returns>
-    protected virtual async Task<bool> HandleExceptionAsync(TContext context, CancellationToken cancellationToken)
+    protected virtual async ValueTask<bool> HandleExceptionAsync(TContext context, CancellationToken cancellationToken)
     {
         if (ErrorHandlingPredicate is not null && !ErrorHandlingPredicate(context))
             return false;

diff --git a/src/PowerPipe/Builder/Steps/LazyStep.cs b/src/PowerPipe/Builder/Steps/LazyStep.cs
@@ -36,10 +36,10 @@ internal LazyStep(Func<IStepBase<TContext>> factory)
     /// <param name="context">The context on which the step operates.</param>
     /// <param name="cancellationToken">A cancellation token to cancel the operation.</param>
     /// <returns>A task representing the asynchronous operation.</returns>
-    protected override async Task ExecuteInternalAsync(TContext context, CancellationToken cancellationToken)
+    protected override async ValueTask ExecuteInternalAsync(TContext context, CancellationToken cancellationToken)
     {
         StepExecuted = true;
 
         await _step.Value.ExecuteAsync(context, cancellationToken);
     }
-}
+}
diff --git a/src/PowerPipe/Builder/Steps/ParallelStep.cs b/src/PowerPipe/Builder/Steps/ParallelStep.cs
@@ -32,7 +32,7 @@ public ParallelStep(int maxDegreeOfParallelism, PipelineBuilder<TContext, TResul
     /// <param name="context">The context on which the step operates.</param>
     /// <param name="cancellationToken">A cancellation token to cancel the operation.</param>
     /// <returns>A task representing the asynchronous operation.</returns>
-    protected override async Task ExecuteInternalAsync(TContext context, CancellationToken cancellationToken)
+    protected override async ValueTask ExecuteInternalAsync(TContext context, CancellationToken cancellationToken)
     {
         StepExecuted = true;
 
@@ -47,4 +47,4 @@ protected override async Task ExecuteInternalAsync(TContext context, Cancellatio
         if (NextStep is not null)
             await NextStep.ExecuteAsync(context, cancellationToken);
     }
-}
+}
-Original file line number
+Diff line change
@@ Expand Up @@
         public int Test1 { get; set; }
         public override SamplePipelineResult GetPipelineResult() => null;
-    };
+    }